Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1860693004: Allow custom inspector header for CORS preflight. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
Mike West, yhirano
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, gavinp+loader_chromium.org, Nate Chapin, kozyatinskiy+blink_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow custom inspector header for CORS preflight. We add this header when inspector is attached and then strip it in the browser. BUG=595229 Committed: https://crrev.com/e2cf1e240a9c54125b3985650685e0b6f3e3a17a Cr-Commit-Position: refs/heads/master@{#385206}

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
dgozman
Hi, Could you please take a look? Thanks, Dmitry
4 years, 8 months ago (2016-04-05 01:49:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860693004/1
4 years, 8 months ago (2016-04-05 01:50:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 03:13:35 UTC) #6
Mike West
Hrm. Yeah, this looks fine, but it's not something that we should allow to hit ...
4 years, 8 months ago (2016-04-05 04:19:06 UTC) #7
Mike West
Looking again, it's fine to land this to fix the CORS bug: LGTM. I'd like ...
4 years, 8 months ago (2016-04-05 14:41:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860693004/1
4 years, 8 months ago (2016-04-05 17:17:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 17:23:40 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:24:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2cf1e240a9c54125b3985650685e0b6f3e3a17a
Cr-Commit-Position: refs/heads/master@{#385206}

Powered by Google App Engine
This is Rietveld 408576698