Chromium Code Reviews
DescriptionFix stack trace symbolization on Windows.
(Joint work with @DavidYen)
This CL requires a companion Chromium CL in order to fix stack trace
symbolization on Windows. It makes the following changes:
- The Windows toolchain installed on the bots and for Chromium
developers is now versioned by hash. It's impractical to parse the
hashes, since doing so would add another strong tie between the
Catapult and Chromium workspaces, so instead support wildcards in
Telemetry's path utilities for finding cdb.exe. (Any version of
this tool will work.)
- It deletes code associated with the obsolete crash_service.
Chromium on Windows now uses Crashpad.
- It relies on Crashpad to honor the BREAKPAD_DUMP_LOCATION
environment variable. (This requires a Chromium change.)
Once this CL is rolled into Chromium, tools/perf's stack trace
unittest will be enabled on Windows, preventing this functionality
from regressing again.
BUG=chromium:561763
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/253a6f9b5e6eef06b8e8a80f8c122e8cf9ed9b8d
Patch Set 1 #
Total comments: 1
Messages
Total messages: 10 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||