Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Issue 1860643002: Fix stack trace symbolization on Windows. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
nednguyen, scottmg
CC:
catapult-reviews_chromium.org, David Yen, scottmg
Base URL:
https://github.com/kenrussell/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fix stack trace symbolization on Windows. (Joint work with @DavidYen) This CL requires a companion Chromium CL in order to fix stack trace symbolization on Windows. It makes the following changes: - The Windows toolchain installed on the bots and for Chromium developers is now versioned by hash. It's impractical to parse the hashes, since doing so would add another strong tie between the Catapult and Chromium workspaces, so instead support wildcards in Telemetry's path utilities for finding cdb.exe. (Any version of this tool will work.) - It deletes code associated with the obsolete crash_service. Chromium on Windows now uses Crashpad. - It relies on Crashpad to honor the BREAKPAD_DUMP_LOCATION environment variable. (This requires a Chromium change.) Once this CL is rolled into Chromium, tools/perf's stack trace unittest will be enabled on Windows, preventing this functionality from regressing again. BUG=chromium:561763 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/253a6f9b5e6eef06b8e8a80f8c122e8cf9ed9b8d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -64 lines) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 5 chunks +4 lines, -49 lines 1 comment Download
M telemetry/telemetry/internal/binary_dependencies.json View 2 chunks +1 line, -11 lines 0 comments Download
M telemetry/telemetry/internal/util/path.py View 3 chunks +13 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/util/path_unittest.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
Ned: please review. Thanks. David, Scott: FYI. Will upload the dependent Chromium CL for your ...
4 years, 8 months ago (2016-04-04 19:02:13 UTC) #2
nednguyen
On 2016/04/04 19:02:13, Ken Russell wrote: > Ned: please review. Thanks. > > David, Scott: ...
4 years, 8 months ago (2016-04-04 19:11:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860643002/1
4 years, 8 months ago (2016-04-04 20:24:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/253a6f9b5e6eef06b8e8a80f8c122e8cf9ed9b8d
4 years, 8 months ago (2016-04-04 20:56:27 UTC) #7
scottmg
https://codereview.chromium.org/1860643002/diff/1/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py (right): https://codereview.chromium.org/1860643002/diff/1/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py#newcode191 telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:191: os.path.join('win_toolchain', 'vs2013_files', '*', 'win_sdk', Does this work? I would ...
4 years, 8 months ago (2016-04-04 21:00:15 UTC) #9
Ken Russell (switch to Gerrit)
4 years, 8 months ago (2016-04-04 21:32:03 UTC) #10
Message was sent while issue was closed.
On 2016/04/04 21:00:15, scottmg wrote:
>
https://codereview.chromium.org/1860643002/diff/1/telemetry/telemetry/interna...
> File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
> (right):
> 
>
https://codereview.chromium.org/1860643002/diff/1/telemetry/telemetry/interna...
> telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:191:
> os.path.join('win_toolchain', 'vs2013_files', '*', 'win_sdk',
> Does this work? I would expect vs_files/*/ after the switch to 2015.

Argh. Thanks for catching this. There was a stale vs2013_files directory in my
depot_tools. I'll submit another CL.

Powered by Google App Engine
This is Rietveld 408576698