Move TranslateManager unit tests out of the browser_tests target.

chrome/browser/translate/translate_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_service.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/translate/core/browser/translate_download_manager.h"
@@ skipping 25 matching lines @@
       g_browser_process->GetApplicationLocale());
 }
 
 // static
 void TranslateService::Shutdown(bool cleanup_pending_fetcher) {
   TranslateDownloadManager* download_manager =
       TranslateDownloadManager::GetInstance();
   if (cleanup_pending_fetcher) {
     download_manager->Shutdown();
   } else {
     // This path is only used by tests.

[hajimehoshi, 2014/03/07 03:54:50]

Can you change this comment?

[danakj, 2014/03/07 16:29:53]

Sure, though I'm not sure what to change it to. I think this comment's truth is
unaffected by this change. It's just used by a different set of tests (browser
tests).

Since we have high latency, I'll CQ this but I'm happy to land a followup to
update the comment if you let me know what it should say.

[hajimehoshi, 2014/03/07 16:56:38]

Sure. However, it might be confusing that this comment mentions 'test' while
both Shutdown and ShutdownForTesting exist. How about s/by tests/by browser
tests/ ?

[danakj, 2014/03/07 17:08:30]

Got it!

     download_manager->set_request_context(NULL);
   }
 }
 
+// static
+void TranslateService::InitializeForTesting() {
+  if (!g_translate_service)

[hajimehoshi, 2014/03/07 03:54:50]

nits: {}

[danakj, 2014/03/07 16:29:53]

oops, thanks. Done.

+    TranslateService::Initialize();
+  else {
+    TranslateDownloadManager::GetInstance()->ResetForTesting();
+    g_translate_service->OnResourceRequestsAllowed();
+  }
+}
+
+// static
+void TranslateService::ShutdownForTesting() {
+  TranslateDownloadManager::GetInstance()->Shutdown();
+}
+
 void TranslateService::OnResourceRequestsAllowed() {
   TranslateLanguageList* language_list =
       TranslateDownloadManager::GetInstance()->language_list();
   if (!language_list) {
     NOTREACHED();
     return;
   }
 
   language_list->SetResourceRequestsAllowed(
       resource_request_allowed_notifier_.ResourceRequestsAllowed());
@@ skipping 12 matching lines @@
   // The bubble UX is not implemented on the non-Aura platforms.
   return false;
 #endif
 }
 
 // static
 void TranslateService::SetUseInfobar(bool value) {
   Initialize();
   g_translate_service->use_infobar_ = value;
 }