Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 186063003: Prevent crash when calling text-related methods on a 2D canvas in a frame-less document. (Closed)

Created:
6 years, 9 months ago by Justin Novosad
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Visibility:
Public.

Description

Prevent crash when calling text-related methods on a 2D canvas in a frame-less document. BUG=343801 R=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168407

Patch Set 1 #

Patch Set 2 : added missing expectation #

Patch Set 3 : fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
A + LayoutTests/fast/canvas/canvas-frameless-document-text.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/canvas/canvas-frameless-document-text-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A LayoutTests/fast/canvas/script-tests/canvas-frameless-document-text.js View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Justin Novosad
6 years, 9 months ago (2014-03-03 20:34:55 UTC) #1
Justin Novosad
PTAL
6 years, 9 months ago (2014-03-03 21:13:04 UTC) #2
Stephen White
LGTM
6 years, 9 months ago (2014-03-03 21:45:01 UTC) #3
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 9 months ago (2014-03-04 15:45:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/186063003/20001
6 years, 9 months ago (2014-03-04 15:45:21 UTC) #5
Justin Novosad
The CQ bit was unchecked by junov@chromium.org
6 years, 9 months ago (2014-03-04 15:46:04 UTC) #6
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 9 months ago (2014-03-04 15:52:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/186063003/40001
6 years, 9 months ago (2014-03-04 15:53:38 UTC) #8
Justin Novosad
6 years, 9 months ago (2014-03-04 20:49:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r168407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698