Chromium Code Reviews Chromium Code Reviews
Issue 1860623002:
Add support for URL.searchParams getter. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/domurl/url-searchparams.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/domurl/url-searchparams.html b/third_party/WebKit/LayoutTests/fast/domurl/url-searchparams.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..20f8790cfeee56a1473c1b305ef65de128a21ddb |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/domurl/url-searchparams.html |
| @@ -0,0 +1,67 @@ |
| +<!DOCTYPE html> |
| +<link rel="help" href="https://url.spec.whatwg.org/#interface-urlsearchparams"> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script> |
| +function assert_type_error(f, msg) { |
| + assert_throws(TypeError(), f, msg); |
| +} |
| + |
| +test(function() { |
| + var url = new URL('http://example.org/?a=b'); |
| + var searchParams = url.searchParams; |
| + assert_true(url.searchParams === searchParams, 'Object identity should hold.'); |
| +}, 'URL.searchParams getter'); |
| + |
| +test(function() { |
| + var url = new URL('http://example.org/?a=b'); |
| + var searchParams = url.searchParams; |
| + assert_equals(searchParams.toString(), 'a=b'); |
| + |
| + searchParams.set('a', 'b'); |
| + assert_equals(url.searchParams.toString(), 'a=b'); |
| + assert_equals(url.search, '?a=b'); |
| + url.search = ''; |
| + assert_equals(url.searchParams.toString(), ''); |
| + assert_equals(url.search, ''); |
| + assert_equals(searchParams.toString(), ''); |
| +}, 'URL.searchParams updating, clearing'); |
| + |
| +test(function() { |
| + 'use strict'; |
|
Mike West
2016/04/05 12:43:51
Why do we need strict mode for this test?
sof
2016/04/05 15:23:18
Assignment to readonly attributes will be ignored
|
| + var urlString = 'http://example.org'; |
| + var url = new URL(urlString); |
| + assert_type_error(function() { url.searchParams = new URLSearchParams(urlString); }); |
| + assert_type_error(function() { url.searchParams = null; }); |
| + assert_type_error(function() { url.searchParams = 2; }); |
| + assert_type_error(function() { url.searchParams = {}; }); |
| +}, 'URL.searchParams setter, invalid values'); |
| + |
| +test(function() { |
| + var url = new URL('http://example.org/file?a=b&c=d'); |
| + var searchParams = url.searchParams; |
| + assert_equals(url.search, '?a=b&c=d'); |
| + assert_equals(searchParams.toString(), 'a=b&c=d'); |
| + |
| + // Test that setting 'search' propagates to the URL object's query |
| + // object. |
| + url.search = 'e=f&g=h'; |
|
Mike West
2016/04/05 12:43:51
Can you add a test that verifies that `?e=f&g=h` h
sof
2016/04/05 15:23:18
Done.
|
| + assert_equals(url.search, '?e=f&g=h'); |
| + assert_equals(searchParams.toString(), 'e=f&g=h'); |
| + |
| + // And in the other direction; altering searchParams propagates |
| + // back to 'search'. |
| + searchParams.append('i', ' j '); |
| + assert_equals(url.search, '?e=f&g=h&i=+j+'); |
| + assert_equals(url.searchParams.toString(), 'e=f&g=h&i=+j+'); |
| + assert_equals(searchParams.get('i'), ' j '); |
| + |
| + searchParams.set('e', 'updated'); |
| + assert_equals(url.search, '?e=updated&g=h&i=+j+'); |
| + assert_equals(searchParams.get('e'), 'updated'); |
| + |
| + var url2 = new URL('http://example.org/file?a=b&c=d'); |
| + assert_equals(url2.search, '?a=b&c=d'); |
| + assert_equals(url2.searchParams.toString(), 'a=b&c=d'); |
| +}, 'URL.searchParams and URL.search setters, update propagation'); |
| +</script> |
