Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 1860613002: [Autofill] Fix heuristics to detect consecutive CVCs. (Closed)

Created:
4 years, 8 months ago by Justin Donnelly
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Autofill] Fix heuristics to detect consecutive CVCs. Added a check after parsing a cvc. If it's the only type parsed so far, check the previous field. If it's also a cvc, just label the current field as a cvc without looking at the next fields. This also fixes some cases where we would label some names as cc-names. BUG=591498, 598873 Review URL: https://codereview.chromium.org/1753253003 Cr-Commit-Position: refs/heads/master@{#380916} (cherry picked from commit a9224ac0cc140b536c8e13099fcf3cfc4cc4a80d) Committed: https://chromium.googlesource.com/chromium/src/+/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -18 lines) Patch
M chrome/test/data/autofill/heuristics/output/117_cc_checkout_macys.com.out View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/118_checkout_cvs.com.out View 2 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 5 chunks +40 lines, -13 lines 0 comments Download
M components/autofill/core/browser/credit_card_field_unittest.cc View 2 chunks +131 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Justin Donnelly
4 years, 8 months ago (2016-04-04 19:16:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0de6f5789e5b3524d36ef9a24a36ee78d24b4e22.

Powered by Google App Engine
This is Rietveld 408576698