Issue 18606: Return ERR_SSL_PROTOCOL_ERROR instead of the default...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18606: Return ERR_SSL_PROTOCOL_ERROR instead of the default... (Closed)

Created:
11 years, 11 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Return ERR_SSL_PROTOCOL_ERROR instead of the default ERR_FAILED when we read EOF during the SSL handshake. The ERR_SSL_PROTOCOL_ERROR error code will allow the TLS-intolerant server handling code in http_network_transaction.cc to kick in if necessary. R=eroman BUG=5894 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8377

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/base/ssl_client_socket_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years, 11 months ago (2009-01-21 03:37:50 UTC) #2

LGTM.

Is there a regression test that can be made for this?

Expand Messages | Collapse Messages