Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860573002: Update SkMorphology ImageFilters to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address code review comments #

Patch Set 3 : clean up #

Patch Set 4 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -137 lines) Patch
M bench/MorphologyBench.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M gm/imagefilters.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 2 7 chunks +34 lines, -33 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 2 3 6 chunks +13 lines, -9 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/localmatriximagefilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M gm/morphology.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 3 chunks +39 lines, -11 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 1 chunk +7 lines, -10 lines 0 comments Download
M samplecode/SampleLayers.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 8 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
robertphillips
4 years, 8 months ago (2016-04-04 17:32:00 UTC) #4
f(malita)
https://codereview.chromium.org/1860573002/diff/1/gm/imagefilterscropped.cpp File gm/imagefilterscropped.cpp (right): https://codereview.chromium.org/1860573002/diff/1/gm/imagefilterscropped.cpp#newcode136 gm/imagefilterscropped.cpp:136: sk_ref_sp(SkColorFilterImageFilter::Create(cf.get(), nullptr, &cropRect)), Don't we need to adopt here ...
4 years, 8 months ago (2016-04-04 18:13:10 UTC) #5
robertphillips
https://codereview.chromium.org/1860573002/diff/1/gm/imagefilterscropped.cpp File gm/imagefilterscropped.cpp (right): https://codereview.chromium.org/1860573002/diff/1/gm/imagefilterscropped.cpp#newcode136 gm/imagefilterscropped.cpp:136: sk_ref_sp(SkColorFilterImageFilter::Create(cf.get(), nullptr, &cropRect)), On 2016/04/04 18:13:09, f(malita) wrote: > ...
4 years, 8 months ago (2016-04-04 19:13:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860573002/40001
4 years, 8 months ago (2016-04-04 19:37:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 19:48:10 UTC) #10
robertphillips
ping
4 years, 8 months ago (2016-04-05 14:33:22 UTC) #11
f(malita)
lgtm
4 years, 8 months ago (2016-04-05 14:33:57 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860573002/60001
4 years, 8 months ago (2016-04-05 14:48:46 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 15:03:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860573002/60001
4 years, 8 months ago (2016-04-05 16:08:40 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:09:39 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/fc11b0afe0ca922a42767d4a656ed640008da1bb

Powered by Google App Engine
This is Rietveld 408576698