Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1860503003: Temporary fix for fuzzer build (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
Reviewers:
*eroman, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary fix for fuzzer build Mojo bindings should be generated for targets that depend on blink_headers, but they currently don't. Until we fix blink_headers we explicitely include the mojo bindings so that they get generated. BUG=599959 Committed: https://crrev.com/fff0d2d26e471b35c2b506996601aeda254c4561 Cr-Commit-Position: refs/heads/master@{#384920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/webcrypto/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ortuno
rsleevi: PTAL at this temporary fix for the fuzz build. I have a patch for ...
4 years, 8 months ago (2016-04-04 15:08:53 UTC) #2
Ryan Sleevi
I am not a good reviewer for this. Adding Eric.
4 years, 8 months ago (2016-04-04 15:12:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860503003/1
4 years, 8 months ago (2016-04-04 15:19:51 UTC) #7
eroman
lgtm
4 years, 8 months ago (2016-04-04 15:54:23 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 16:07:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860503003/1
4 years, 8 months ago (2016-04-04 16:07:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 16:13:44 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 16:15:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fff0d2d26e471b35c2b506996601aeda254c4561
Cr-Commit-Position: refs/heads/master@{#384920}

Powered by Google App Engine
This is Rietveld 408576698