Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1860483002: [v8] Mark layout test for rebase on ES6 instanceof. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Mark layout test for rebase on ES6 instanceof. The new ES6 instanceof semantics have by now shipped in V8 and layout tests can be rebaselined. This one test in question can be handled automatically. R=hablich@chromium.org BUG=chromium:597221, v8:4447 Committed: https://crrev.com/ecaad3bb0a8d80e232990dd9ff4583420034b734 Cr-Commit-Position: refs/heads/master@{#384892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Michael H.: PTAL. Michael S.: FYI.
4 years, 8 months ago (2016-04-04 11:12:16 UTC) #2
Michael Hablich
On 2016/04/04 11:12:16, Michael Starzinger wrote: > Michael H.: PTAL. > Michael S.: FYI. lgtm
4 years, 8 months ago (2016-04-04 11:26:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860483002/1
4 years, 8 months ago (2016-04-04 11:28:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 13:16:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:18:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecaad3bb0a8d80e232990dd9ff4583420034b734
Cr-Commit-Position: refs/heads/master@{#384892}

Powered by Google App Engine
This is Rietveld 408576698