Add a simple API around the pref controlling the default browser prompt.

Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
Committed: https://crrev.com/36fc6321c8e5a3f23ac5b0eeabab26771c7595f7
Cr-Commit-Position: refs/heads/master@{#385739}

[grt (UTC plus 2), 2016-04-06 16:55:30]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2016-04-06 16:57:03]

Description was changed from

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
==========

to

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
==========

[grt (UTC plus 2), 2016-04-06 16:57:03]

grt@chromium.org changed reviewers:
+ msw@chromium.org

[grt (UTC plus 2), 2016-04-06 17:00:47]

Hi Mike. You reviewed this as a part of
https://codereview.chromium.org/1748773002/, which is still in flux. I think
makes sense to land this part on its own, since having an API around the pref is
a bit cleaner than having random Chrome code set or clear the pref here and
there. Please take a look, thanks.

[grt (UTC plus 2), 2016-04-06 17:00:58]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 17:01:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860423003/20001

[commit-bot: I haz the power, 2016-04-06 18:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:00:54]

Dry run: This issue passed the CQ dry run.

[msw, 2016-04-06 22:04:55]

lgtm with one sanity check question.

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/default_browser_prompt.cc:293:
profile->GetPrefs()->ClearPref(prefs::kCheckDefaultBrowser);
q: does this yield equivalent behavior as setting the pref to true?
(just checking that this won't regress ResetCheckDefaultBrowserPref, etc.)

[grt (UTC plus 2), 2016-04-07 00:49:30]

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/default_browser_prompt.cc:293:
profile->GetPrefs()->ClearPref(prefs::kCheckDefaultBrowser);
On 2016/04/06 22:04:55, msw wrote:
> q: does this yield equivalent behavior as setting the pref to true?
> (just checking that this won't regress ResetCheckDefaultBrowserPref, etc.)

The default is true at the point of registration
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...),
so I figured that clearing it is better than setting it since it will remove a
few bytes from the pref file. Is there any risk in this?

[msw, 2016-04-07 01:42:59]

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
File chrome/browser/ui/startup/default_browser_prompt.cc (right):

https://codereview.chromium.org/1860423003/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/default_browser_prompt.cc:293:
profile->GetPrefs()->ClearPref(prefs::kCheckDefaultBrowser);
On 2016/04/07 00:49:30, grt (very slow) wrote:
> On 2016/04/06 22:04:55, msw wrote:
> > q: does this yield equivalent behavior as setting the pref to true?
> > (just checking that this won't regress ResetCheckDefaultBrowserPref, etc.)
> 
> The default is true at the point of registration
>
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...),
> so I figured that clearing it is better than setting it since it will remove a
> few bytes from the pref file. Is there any risk in this?

Not afaik, so that sg. Still lgtm

[grt (UTC plus 2), 2016-04-07 13:23:08]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-04-07 13:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860423003/20001

[commit-bot: I haz the power, 2016-04-07 13:28:42]

Description was changed from

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
==========

to

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
==========

[commit-bot: I haz the power, 2016-04-07 13:28:43]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-04-07 13:31:07]

Description was changed from

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128
==========

to

==========
Add a simple API around the pref controlling the default browser prompt.

This simplifies subsequent changes to the pref/prompt.

BUG=589128

Committed: https://crrev.com/36fc6321c8e5a3f23ac5b0eeabab26771c7595f7
Cr-Commit-Position: refs/heads/master@{#385739}
==========

[commit-bot: I haz the power, 2016-04-07 13:31:08]

Patchset 1 (id:??) landed as
https://crrev.com/36fc6321c8e5a3f23ac5b0eeabab26771c7595f7
Cr-Commit-Position: refs/heads/master@{#385739}