Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1860413002: Fix the potential crash on ChromeOS. (Closed)

Created:
4 years, 8 months ago by Azure Wei
Modified:
4 years, 8 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the potential crash of ProfileCompare::operator() on ChromeOS. BUG=583365 TEST=None Committed: https://crrev.com/f90f5153c328c26417a0f66b9126dcb8830995e9 Cr-Commit-Position: refs/heads/master@{#385421}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Azure Wei
Hello Shu, please review this cl. Thank you!
4 years, 8 months ago (2016-04-06 06:13:26 UTC) #3
Shu Chen
lgtm
4 years, 8 months ago (2016-04-06 08:40:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860413002/1
4 years, 8 months ago (2016-04-06 08:41:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/117449) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-06 08:54:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860413002/20001
4 years, 8 months ago (2016-04-06 09:02:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 09:40:14 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:41:15 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f90f5153c328c26417a0f66b9126dcb8830995e9
Cr-Commit-Position: refs/heads/master@{#385421}

Powered by Google App Engine
This is Rietveld 408576698