Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 18604: Fix a timing issue that caused gears to fail to load sometimes.... (Closed)

Created:
10 years, 7 months ago by Matt Perry
Modified:
8 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a timing issue that caused gears to fail to load sometimes. BUG=http://b/issue?id=1559007 BUG=http://code.google.com/p/chromium/issues/detail?id=4219 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8417

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/plugin_process_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/plugin/chrome_plugin_host.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
10 years, 7 months ago (2009-01-21 02:27:28 UTC) #1
michaeln
Is gears-in-renderer similarly plagued by this problem or not? http://codereview.chromium.org/18604/diff/1/3 File chrome/browser/plugin_process_host.cc (right): http://codereview.chromium.org/18604/diff/1/3#newcode434 Line ...
10 years, 7 months ago (2009-01-21 19:38:07 UTC) #2
Matt Perry
On 2009/01/21 19:38:07, michaeln wrote: > Is gears-in-renderer similarly plagued by this problem or not? ...
10 years, 7 months ago (2009-01-21 19:58:10 UTC) #3
Matt Perry
http://codereview.chromium.org/18604/diff/1/3 File chrome/browser/plugin_process_host.cc (right): http://codereview.chromium.org/18604/diff/1/3#newcode434 Line 434: if (!data_dir.empty()) { On 2009/01/21 19:38:07, michaeln wrote: ...
10 years, 7 months ago (2009-01-21 19:58:17 UTC) #4
michaeln
10 years, 7 months ago (2009-01-21 20:04:37 UTC) #5
LGTM

http://codereview.chromium.org/18604/diff/216/218
File chrome/browser/plugin_process_host.cc (right):

http://codereview.chromium.org/18604/diff/216/218#newcode516
Line 516: DHECK(!data_dir.empty());
typo... C is missing

Powered by Google App Engine
This is Rietveld 408576698