Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1860333002: More iOS swarming bot fixes (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 8 months ago
Reviewers:
borenet, rmistry, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More iOS swarming bot fixes - Copy the packaged app into xcodebuild/... - Isolate ios/bin directory BUG=skia:5155 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860333002 Committed: https://skia.googlesource.com/skia/+/b0070197ff10500a9cdcc6bb0984c670de58f523

Patch Set 1 #

Patch Set 2 : add includes #

Patch Set 3 : Fix os #

Patch Set 4 : More paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
A + infra/bots/ios_bin.isolate View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/perf_skia.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/test_skia.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/ios/bin/ios_run_skia View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/ios/bin/ios_setup.sh View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
borenet
4 years, 8 months ago (2016-04-06 17:52:34 UTC) #4
rmistry
lgtm
4 years, 8 months ago (2016-04-06 17:55:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860333002/60001
4 years, 8 months ago (2016-04-06 17:59:47 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 18:18:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860333002/60001
4 years, 8 months ago (2016-04-06 18:37:58 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 18:39:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b0070197ff10500a9cdcc6bb0984c670de58f523

Powered by Google App Engine
This is Rietveld 408576698