Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 18603012: Make BaselineOptimizer virtual test suite aware. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 39f5b6e1f371e97f365b8788070bd11a65ab7adc..5f65b3cba56a1ff17746997e231b00b611c36f2d 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -212,6 +212,12 @@ class Port(object):
baseline_search_paths = self.baseline_search_path()
return baseline_search_paths[0]
+ def virtual_baseline_search_path(self, test_name):
+ suite = self.lookup_virtual_suite(test_name)
+ if not suite:
+ return None
+ return [self._filesystem.join(path, suite.name) for path in self.default_baseline_search_path()]
+
def baseline_search_path(self):
return self.get_option('additional_platform_directory', []) + self._compare_baseline() + self.default_baseline_search_path()
@@ -1353,12 +1359,21 @@ class Port(object):
virtual_tests.extend(suite.tests.keys())
return virtual_tests
- def lookup_virtual_test_base(self, test_name):
+ def is_virtual_test(self, test_name):
+ return bool(self.lookup_virtual_suite(test_name))
+
+ def lookup_virtual_suite(self, test_name):
for suite in self.populated_virtual_test_suites():
if test_name.startswith(suite.name):
- return test_name.replace(suite.name, suite.base, 1)
+ return suite
return None
+ def lookup_virtual_test_base(self, test_name):
+ suite = self.lookup_virtual_suite(test_name)
+ if not suite:
+ return None
+ return test_name.replace(suite.name, suite.base, 1)
+
def lookup_virtual_test_args(self, test_name):
for suite in self.populated_virtual_test_suites():
if test_name.startswith(suite.name):

Powered by Google App Engine
This is Rietveld 408576698