Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/ui/sync/sync_promo_ui.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Common layout constants Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/sync_promo_ui.cc
diff --git a/chrome/browser/ui/sync/sync_promo_ui.cc b/chrome/browser/ui/sync/sync_promo_ui.cc
index 8698f14e5c33fe7eb6f89af68d40d70001c5b06a..eef468ebf6e1e4bb8b159b3c056518053f169e7c 100644
--- a/chrome/browser/ui/sync/sync_promo_ui.cc
+++ b/chrome/browser/ui/sync/sync_promo_ui.cc
@@ -97,10 +97,6 @@ bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {
if (net::NetworkChangeNotifier::IsOffline())
return false;
- // Don't show if the profile is an incognito.
- if (profile->IsOffTheRecord())
- return false;
-
// Don't show for managed profiles.
if (profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged))
return false;
@@ -143,6 +139,10 @@ bool SyncPromoUI::ShouldShowSyncPromoAtStartup(Profile* profile,
bool is_new_profile) {
DCHECK(profile);
+ // Don't show if the profile is an incognito.
+ if (profile->IsOffTheRecord())
+ return false;
+
if (!ShouldShowSyncPromo(profile))
return false;

Powered by Google App Engine
This is Rietveld 408576698