Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Common layout constants Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 992b88a5fd5732f5da862840db5412c3072d516a..18e9981ccf39e8bb9875d5ae122cad3c287635dc 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -180,8 +180,15 @@ void LogHistogramValue(SyncPromoUI::Source source, int action) {
UMA_HISTOGRAM_ENUMERATION("Signin.AppsPageLinkActions", action,
one_click_signin::HISTOGRAM_MAX);
break;
+ case SyncPromoUI::SOURCE_BOOKMARK_BUBBLE:
+ UMA_HISTOGRAM_ENUMERATION("Signin.BookmarkBubbleActions", action,
+ one_click_signin::HISTOGRAM_MAX);
+ break;
default:
- NOTREACHED() << "Invalid Source";
+ // This switch statement needs to be updated when the enum Source changes.
+ COMPILE_ASSERT(SyncPromoUI::SOURCE_UNKNOWN == 9,
+ kSourceEnumHasChangedButNotThisSwitchStatement);
+ NOTREACHED();
return;
}
UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,

Powered by Google App Engine
This is Rietveld 408576698