Bookmark sync promo for Views.

chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"
+
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/sync/sync_promo_ui.h"
+
+BookmarkBubbleSignInDelegate::BookmarkBubbleSignInDelegate(Browser* browser)
+    : browser_(browser),
+      profile_(browser->profile()),
+      desktop_type_(browser->host_desktop_type()) {
+  BrowserList::AddObserver(this);
+}
+
+BookmarkBubbleSignInDelegate::~BookmarkBubbleSignInDelegate() {
+  BrowserList::RemoveObserver(this);
+}
+
+void BookmarkBubbleSignInDelegate::OnSignInLinkClicked() {
+  EnsureBrowser();
+  chrome::ShowBrowserSignin(browser_, SyncPromoUI::SOURCE_BOOKMARK_BUBBLE);
+}
+
+void BookmarkBubbleSignInDelegate::OnBrowserRemoved(Browser* browser) {
+  if (browser == browser_)
+    browser_ = NULL;
+}
+
+void BookmarkBubbleSignInDelegate::EnsureBrowser() {
+  if (!browser_) {
+    Profile* original_profile = profile_->GetOriginalProfile();
+    browser_ = chrome::FindLastActiveWithProfile(original_profile,
+                                                 desktop_type_);
+    if (!browser_) {
+      browser_ = new Browser(Browser::CreateParams(original_profile,
+                                                   desktop_type_));
+    }
+    browser_->window()->Show();

[sky, 2013/07/18 16:08:42]

DCHECK(tabstrip not empty?)

[fdoray, 2013/07/18 18:49:12]

The tab strip of a newly created browser IS empty. A new tab is opened by
chrome::ShowBrowserSignin. Do you want this check after line 27? Is the problem
that I show the browser before creating the first tab?

Let me know if I made the right change.

[sky, 2013/07/19 00:02:32]

Yes, sorry, DCHECK after ShowBrowserSignin.

+  }
+}