chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc - Issue 18603006: Bookmark sync promo for Views.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

Issue 18603006: Bookmark sync promo for Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Common layout constants Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"

	6 #include "chrome/browser/ui/chrome_pages.h"
	sky 2013/07/17 16:08:02 nit: newline between 5/6. nit: newline between 5/6. fdoray 2013/07/17 19:39:56 Done. Show quoted text On 2013/07/17 16:08:02, sky wrote: > nit: newline between 5/6. Done.
	7 #include "chrome/browser/ui/sync/sync_promo_ui.h"

	8

	9 BookmarkBubbleSignInDelegate::BookmarkBubbleSignInDelegate(Browser* browser)

	10 : browser_(browser) {}

	11

	12 void BookmarkBubbleSignInDelegate::OnSignInLinkClicked() {

	13 chrome::ShowBrowserSignin(browser_, SyncPromoUI::SOURCE_BOOKMARK_BUBBLE);
	sky 2013/07/17 16:08:02 How do you know browser_ is valid at the time the How do you know browser_ is valid at the time the callback is invoked? fdoray 2013/07/17 19:39:56 Done. If browser_ is no longer valid, I pick eithe Done. If browser_ is no longer valid, I pick either the most recently used browser for \|profile_\| or I create a new one. On 2013/07/17 16:08:02, sky wrote: Show quoted text > How do you know browser_ is valid at the time the callback is invoked?
	14 }

OLD	NEW