Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html

Issue 1860293003: Serialize original node when dragging a link instead of synthesizing HTML. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html
diff --git a/third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html b/third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html
index e0cdad37f204d5165520e5547c6de9e9ddd20976..2388988d10a7a00ded08f69346ca60c6f26c1135 100644
--- a/third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html
+++ b/third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html
@@ -57,6 +57,9 @@ function dragLink(srcId, targetId)
eventSender.mouseMoveTo(x, y);
eventSender.mouseUp();
+
+ // Clear id on the cloned link created from the drag and drop.
+ delete document.querySelector("a[id]").removeAttribute('id');
yosin_UTC9 2016/04/06 01:17:29 Why do we need to have delete-operator here? Node.
dcheng 2016/04/06 01:20:33 Oops, meant to delete the delete.
}
function verifier() {
@@ -92,11 +95,11 @@ function verifyLink(linkId, linkNumber)
log("Link is " + anchors[linkNumber].href);
var passed = true;
if (anchors[linkNumber].href != originalTarget) {
- log("Failure! Link targets differ");
+ log("Failure! Expected target: " + anchors[linkNumber].href + ", actual target: " + originalTarget);
passed = false;
}
if (anchors[linkNumber].innerText != originalText) {
- log("Failure! Link texts differ");
+ log("Failure! Expected text: " + anchors[linkNumber].innerText + ", actual text: " + originalText);
passed = false;
}
}

Powered by Google App Engine
This is Rietveld 408576698