Serialize original node when dragging a link instead of synthesizing HTML.

Serialize original node when dragging a link instead of synthesizing HTML.

This preserves the original attributes, like what already happens for
image and selection drags today.

BUG=590912
Committed: https://crrev.com/3accf1e624bb65f3c4b594e646b54b28dab05c21
Cr-Commit-Position: refs/heads/master@{#385378}

[dcheng, 2016-04-05 23:50:35]

dcheng@chromium.org changed reviewers:
+ yosin@chromium.org

[dcheng, 2016-04-05 23:51:02]

Description was changed from

==========
Serialize original node when dragging a link instead of synthesizing HTML.

BUG=590912
==========

to

==========
Serialize original node when dragging a link instead of synthesizing HTML.

This preserves the original attributes, like what already happens for
image and selection drags today.

BUG=590912
==========

[yosin_UTC9, 2016-04-06 01:17:29]

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
(right):

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20:
text/html: <a id="linkTest" href="http://www.example.com/"
ondragstart="dragStartTest(event)">Link</a>
Optional: If you rewrite this test to use w3c test harness, we're lucky! ;-)

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html (right):

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html:62: delete
document.querySelector("a[id]").removeAttribute('id');
Why do we need to have delete-operator here? Node.removeAttribute() returns no
value.

[dcheng, 2016-04-06 01:20:33]

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
(right):

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20:
text/html: <a id="linkTest" href="http://www.example.com/"
ondragstart="dragStartTest(event)">Link</a>
On 2016/04/06 at 01:17:29, Yosi_UTC9 wrote:
> Optional: If you rewrite this test to use w3c test harness, we're lucky! ;-)

Ehhh... unless there's a really straightforward and easy way to do it, I'd
rather not, I'm just trying to reduce the backlog of data transfer bugs. Is
there a conversion cheatsheet somewhere? This seems like something that
blink-dev@ at large could help out with.

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html (right):

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/pasteboard/drop-link.html:62: delete
document.querySelector("a[id]").removeAttribute('id');
On 2016/04/06 at 01:17:29, Yosi_UTC9 wrote:
> Why do we need to have delete-operator here? Node.removeAttribute() returns no
value.

Oops, meant to delete the delete.

[yosin_UTC9, 2016-04-06 01:32:09]

lgtm

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt
(right):

https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20:
text/html: <a id="linkTest" href="http://www.example.com/"
ondragstart="dragStartTest(event)">Link</a>
On 2016/04/06 at 01:20:33, dcheng wrote:
> On 2016/04/06 at 01:17:29, Yosi_UTC9 wrote:
> > Optional: If you rewrite this test to use w3c test harness, we're lucky! ;-)
> 
> Ehhh... unless there's a really straightforward and easy way to do it, I'd
rather not, I'm just trying to reduce the backlog of data transfer bugs. Is
there a conversion cheatsheet somewhere? This seems like something that
blink-dev@ at large could help out with.

Chest sheet is a good idea! It helps to write test and upstream to w3c.
I'll discuss with tkent@.

[dcheng, 2016-04-06 01:35:09]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-06 01:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860293003/20001

[commit-bot: I haz the power, 2016-04-06 03:26:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 03:27:12]

Description was changed from

==========
Serialize original node when dragging a link instead of synthesizing HTML.

This preserves the original attributes, like what already happens for
image and selection drags today.

BUG=590912
==========

to

==========
Serialize original node when dragging a link instead of synthesizing HTML.

This preserves the original attributes, like what already happens for
image and selection drags today.

BUG=590912

Committed: https://crrev.com/3accf1e624bb65f3c4b594e646b54b28dab05c21
Cr-Commit-Position: refs/heads/master@{#385378}
==========

[commit-bot: I haz the power, 2016-04-06 03:27:13]

Patchset 2 (id:??) landed as
https://crrev.com/3accf1e624bb65f3c4b594e646b54b28dab05c21
Cr-Commit-Position: refs/heads/master@{#385378}