Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1860293003: Serialize original node when dragging a link instead of synthesizing HTML. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Serialize original node when dragging a link instead of synthesizing HTML. This preserves the original attributes, like what already happens for image and selection drags today. BUG=590912 Committed: https://crrev.com/3accf1e624bb65f3c4b594e646b54b28dab05c21 Cr-Commit-Position: refs/heads/master@{#385378}

Patch Set 1 #

Total comments: 5

Patch Set 2 : delete delete #

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 8 months ago (2016-04-05 23:50:36 UTC) #2
yosin_UTC9
https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt File third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt (right): https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt#newcode20 third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20: text/html: <a id="linkTest" href="http://www.example.com/" ondragstart="dragStartTest(event)">Link</a> Optional: If you rewrite ...
4 years, 8 months ago (2016-04-06 01:17:29 UTC) #4
dcheng
https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt File third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt (right): https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt#newcode20 third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20: text/html: <a id="linkTest" href="http://www.example.com/" ondragstart="dragStartTest(event)">Link</a> On 2016/04/06 at 01:17:29, ...
4 years, 8 months ago (2016-04-06 01:20:33 UTC) #5
yosin_UTC9
lgtm https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt File third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt (right): https://codereview.chromium.org/1860293003/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt#newcode20 third_party/WebKit/LayoutTests/editing/pasteboard/dragstart-contains-default-content-expected.txt:20: text/html: <a id="linkTest" href="http://www.example.com/" ondragstart="dragStartTest(event)">Link</a> On 2016/04/06 at ...
4 years, 8 months ago (2016-04-06 01:32:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860293003/20001
4 years, 8 months ago (2016-04-06 01:35:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 03:26:04 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 03:27:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3accf1e624bb65f3c4b594e646b54b28dab05c21
Cr-Commit-Position: refs/heads/master@{#385378}

Powered by Google App Engine
This is Rietveld 408576698