third_party/WebKit/Source/platform/LayoutUnit.h - Issue 1860273002: Fix scrollIntoViewIfNeeded when scroll box has no height or width.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LayoutUnit.h

Issue 1860273002: Fix scrollIntoViewIfNeeded when scroll box has no height or width. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed broken composition test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ScrollAlignment.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/LayoutUnit.h

diff --git a/third_party/WebKit/Source/platform/LayoutUnit.h b/third_party/WebKit/Source/platform/LayoutUnit.h

index f41fff9d29903e0c99cf875bd7d0701428c2a03b..6611ca345d28169f96664a8977cf5e2fecc7521d 100644

--- a/third_party/WebKit/Source/platform/LayoutUnit.h

+++ b/third_party/WebKit/Source/platform/LayoutUnit.h

@@ -62,7 +62,6 @@ class LayoutUnit {

DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

public:

LayoutUnit() : m_value(0) { }

- // TODO(leviw): All of the below constructors should be explicit. crbug.com/581254

explicit LayoutUnit(int value) { setValue(value); }

explicit LayoutUnit(unsigned short value) { setValue(value); }

explicit LayoutUnit(unsigned value) { setValue(value); }

« no previous file with comments | « third_party/WebKit/Source/core/layout/ScrollAlignment.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »