Issue 18602003: Encapsulate compare nil ic_state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18602003: Encapsulate compare nil ic_state. (Closed)

Created:
7 years, 5 months ago by oliv

Modified:
7 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -185 lines)			Patch
M	src/code-stubs.h	View	4 chunks	+34 lines, -54 lines	0 comments	Download
M	src/code-stubs.cc	View	4 chunks	+20 lines, -13 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/type-info.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/cctest/test-compare-nil-ic-stub.cc	View	1 chunk	+0 lines, -91 lines	0 comments	Download

Total messages: 3 (0 generated)

oliv

Just saw that you followed my ugly example of exposing the ic-state internals via ExtractTypesFromExtraICState. ...

7 years, 5 months ago (2013-07-10 16:49:08 UTC) #1

oliv

7 years, 5 months ago (2013-07-11 17:21:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15639 (presubmit successful).