Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1860193002: Stop supporting CSP-Report-Only in meta elements (Closed)

Created:
4 years, 8 months ago by estark
Modified:
4 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop supporting CSP-Report-Only in meta elements Report-Only mode isn't allowed in <meta> elements per CSP 1.1, and neither Firefox nor Edge supports it. This CL drops support and updates layout tests that were relying on it. BUG=600513 Committed: https://crrev.com/9f6871d833bca118dfa14d2888afb55e390a90e1 Cr-Commit-Position: refs/heads/master@{#385419}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add layout test #

Patch Set 4 : fix weird indentation #

Messages

Total messages: 10 (5 generated)
estark
mkwst: one last kill-a-CSP-feature-in-meta-elements CL for you :)
4 years, 8 months ago (2016-04-05 23:56:00 UTC) #3
Mike West
LGTM, thanks!
4 years, 8 months ago (2016-04-06 06:07:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860193002/60001
4 years, 8 months ago (2016-04-06 06:09:32 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-06 09:29:25 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:31:53 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9f6871d833bca118dfa14d2888afb55e390a90e1
Cr-Commit-Position: refs/heads/master@{#385419}

Powered by Google App Engine
This is Rietveld 408576698