Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1860163003: Use MD-style focus indicator on DL shelf items. (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, tfarina, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MD-style focus indicator on DL shelf items. TEST=Press F6 until a download item is focused. BUG=538172, 602158 Committed: https://crrev.com/c61557028637fa564d3fb64eb91d019e98f3982b Cr-Commit-Position: refs/heads/master@{#386509}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
https://codereview.chromium.org/1860163003/diff/1/chrome/browser/ui/views/download/download_shelf_view.cc File chrome/browser/ui/views/download/download_shelf_view.cc (right): https://codereview.chromium.org/1860163003/diff/1/chrome/browser/ui/views/download/download_shelf_view.cc#newcode109 chrome/browser/ui/views/download/download_shelf_view.cc:109: return ui::MaterialDesignController::IsModeMaterial() ? 1 : kTopBottomPadding; this change leaves ...
4 years, 8 months ago (2016-04-11 19:22:44 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-11 20:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860163003/20001
4 years, 8 months ago (2016-04-11 21:15:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 23:08:07 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 23:09:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c61557028637fa564d3fb64eb91d019e98f3982b
Cr-Commit-Position: refs/heads/master@{#386509}

Powered by Google App Engine
This is Rietveld 408576698