Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: third_party/WebKit/Source/wtf/Optional.h

Issue 1860143002: Allow Vector<Optional> and Optional::get() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/Optional.h
diff --git a/third_party/WebKit/Source/wtf/Optional.h b/third_party/WebKit/Source/wtf/Optional.h
index 1c2e422f522d6cb210e65f7ed6f71cf3597c6be4..a28bd804308c3e218f80c575ac77cabae5448102 100644
--- a/third_party/WebKit/Source/wtf/Optional.h
+++ b/third_party/WebKit/Source/wtf/Optional.h
@@ -28,12 +28,14 @@ namespace WTF {
// recorder.emplace(constructor, args, here);
// // recorder destroyed at end of scope
//
+// It can be used in WTF::Vector.
+//
// Note in particular that unlike a pointer, though, dereferencing a const
// optional yields a const reference.
template <typename T>
class Optional final {
- DISALLOW_NEW();
+ DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
WTF_MAKE_NONCOPYABLE(Optional);
public:
Optional() : m_ptr(nullptr) { }
@@ -50,6 +52,8 @@ public:
const T& operator*() const { ASSERT_WITH_SECURITY_IMPLICATION(m_ptr); return *m_ptr; }
T* operator->() { ASSERT_WITH_SECURITY_IMPLICATION(m_ptr); return m_ptr; }
const T* operator->() const { ASSERT_WITH_SECURITY_IMPLICATION(m_ptr); return m_ptr; }
+ T* get() { return m_ptr; }
+ const T* get() const { return m_ptr; }
template <typename... Args>
void emplace(Args&&... args)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698