Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/extensions/extension_action.h

Issue 186013003: Persist browseraction properties across restarts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action.h
diff --git a/chrome/browser/extensions/extension_action.h b/chrome/browser/extensions/extension_action.h
index 69095b4aa541c6d6acf28d1ce0ef04fea19bb455..e929041ca6986ac008940525fc443c8c5f1e6bdd 100644
--- a/chrome/browser/extensions/extension_action.h
+++ b/chrome/browser/extensions/extension_action.h
@@ -68,9 +68,6 @@ class ExtensionAction {
std::string id() const { return id_; }
void set_id(const std::string& id) { id_ = id; }
- bool has_changed() const { return has_changed_; }
- void set_has_changed(bool value) { has_changed_ = value; }
-
// Set the url which the popup will load when the user clicks this action's
// icon. Setting an empty URL will disable the popup for a given tab.
void SetPopupUrl(int tab_id, const GURL& url);
@@ -182,6 +179,16 @@ class ExtensionAction {
int tab_id,
const gfx::Size& spacing) const;
+ // Determine whether or not the ExtensionAction has a value set for the given
+ // |tab_id| for each property.
+ bool HasPopupUrl(int tab_id) const;
+ bool HasTitle(int tab_id) const;
+ bool HasBadgeText(int tab_id) const;
+ bool HasBadgeBackgroundColor(int tab_id) const;
+ bool HasBadgeTextColor(int tab_id) const;
+ bool HasIsVisible(int tab_id) const;
+ bool HasIcon(int tab_id) const;
+
private:
// Returns width of the current icon for tab_id.
// TODO(tbarzic): The icon selection is done in ExtensionActionIconFactory.
@@ -256,10 +263,6 @@ class ExtensionAction {
// needed for compat with an older version of the page actions API.
std::string id_;
- // True if the ExtensionAction's settings have changed from what was
- // specified in the manifest.
- bool has_changed_;
-
DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
};
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698