Persist browseraction properties across restarts

chrome/browser/extensions/extension_action.h

Index: chrome/browser/extensions/extension_action.h
diff --git a/chrome/browser/extensions/extension_action.h b/chrome/browser/extensions/extension_action.h
index 69095b4aa541c6d6acf28d1ce0ef04fea19bb455..d444ba0fd61a91764ba3812b66b2edfaa3d054ff 100644
--- a/chrome/browser/extensions/extension_action.h
+++ b/chrome/browser/extensions/extension_action.h
@@ -68,9 +68,6 @@ class ExtensionAction {
   std::string id() const { return id_; }
   void set_id(const std::string& id) { id_ = id; }
 
-  bool has_changed() const { return has_changed_; }
-  void set_has_changed(bool value) { has_changed_ = value; }
-
   // Set the url which the popup will load when the user clicks this action's
   // icon.  Setting an empty URL will disable the popup for a given tab.
   void SetPopupUrl(int tab_id, const GURL& url);
@@ -182,6 +179,16 @@ class ExtensionAction {
                                   int tab_id,
                                   const gfx::Size& spacing) const;
 
+  // Determine whether or not the ExtensionAction has default values for each
+  // property.
+  bool HasPopupUrl() const;

[Jeffrey Yasskin, 2014/03/05 20:23:33]

These need to take a tab_id, like the Get* functions, and return whether that
tab has the specified attribute.

[Devlin, 2014/03/05 23:04:31]

Whoops, misunderstood earlier. Done.

+  bool HasTitle() const;
+  bool HasBadgeText() const;
+  bool HasBadgeBackgroundColor() const;
+  bool HasBadgeTextColor() const;
+  bool HasIsVisible() const;
+  bool HasIcon() const;
+
  private:
   // Returns width of the current icon for tab_id.
   // TODO(tbarzic): The icon selection is done in ExtensionActionIconFactory.
@@ -256,10 +263,6 @@ class ExtensionAction {
   // needed for compat with an older version of the page actions API.
   std::string id_;
 
-  // True if the ExtensionAction's settings have changed from what was
-  // specified in the manifest.
-  bool has_changed_;
-
   DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
 };