Add infrastructure for partial layouts

Source/core/rendering/RenderObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 728 matching lines @@
 }
 
 #ifndef NDEBUG
 void RenderObject::checkBlockPositionedObjectsNeedLayout()
 {
     ASSERT(!needsLayout());
 
     if (isRenderBlock())
         toRenderBlock(this)->checkPositionedObjectsNeedLayout();
 }
+
+void RenderObject::checkNotInPartialLayout()
+{
+    // During partial layout, setNeedsLayout(true or false) should not be called.
+    ASSERT(!frameView()->shouldStopPartialLayout());
+}
 #endif
 
 void RenderObject::setPreferredLogicalWidthsDirty(bool shouldBeDirty, MarkingBehavior markParents)
 {
     bool alreadyDirty = preferredLogicalWidthsDirty();
     m_bitfields.setPreferredLogicalWidthsDirty(shouldBeDirty);
     if (shouldBeDirty && !alreadyDirty && markParents == MarkContainingBlockChain && (isText() || !style()->hasOutOfFlowPosition()))
         invalidateContainerPreferredLogicalWidths();
 }
 
@@ skipping 2012 matching lines @@
             result.setInnerNonSharedNode(node);
         result.setLocalPoint(point);
     }
 }
 
 bool RenderObject::nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& /*locationInContainer*/, const LayoutPoint& /*accumulatedOffset*/, HitTestAction)
 {
     return false;
 }
 
+FrameView* RenderObject::frameView() const

[eseidel, 2013/08/20 21:00:39]

I think we should explain why this should never be null for RenderObject and
ASSERT it.  I would do this in a separate patch.

+{
+    // FIXME: Should we check isRooted()?

[esprehn, 2013/08/23 20:47:27]

There's no reason to.

[pdr., 2013/08/26 05:50:40]

Done.

+    if (RenderView* renderView = view())

[esprehn, 2013/08/23 20:47:27]

Don't do this, just do return document()->view();

What you have is actually:

m_node->document()->renderView()->frameView()

instead you want:

m_node->document()->view()

which is what document()->view() does.

[pdr., 2013/08/26 05:50:40]

Done.

+        return renderView->frameView();
+    return 0;
+}
+
 void RenderObject::scheduleRelayout()
 {
     if (isRenderView()) {
         FrameView* view = toRenderView(this)->frameView();
         if (view)
             view->scheduleRelayout();
     } else {
         if (isRooted()) {
             if (RenderView* renderView = view()) {
                 if (FrameView* frameView = renderView->frameView())
@@ skipping 540 matching lines @@
 {
     if (object1) {
         const WebCore::RenderObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
     }
 }
 
 #endif