extensions/renderer/DEPS - Issue 1860083002: [chrome.displaySource][WiFi Display] Media pipeline infrastructure

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/DEPS

Issue 1860083002: [chrome.displaySource][WiFi Display] Media pipeline infrastructure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from Antony Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/extensions.gypi ('k') | extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.h » ('j') | extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/translate/core/language_detection",	2 "+components/translate/core/language_detection",

3 "+content/public/child",	3 "+content/public/child",

4 "+content/public/renderer",	4 "+content/public/renderer",

5	5

6 "+gin",	6 "+gin",

	7 "+media/base",
	ddorwin 2016/04/08 17:41:31 It seems that we shouldn't give all extensions cod It seems that we shouldn't give all extensions code access to these files. You can add a new DEPS file exactly where you need it. OTOH, these two are already in content/public/renderer/DEPS. DaleCurtis 2016/04/08 17:53:59 Whoops missed this reply, DEPS should always be na Show quoted text On 2016/04/08 at 17:41:31, ddorwin wrote: > It seems that we shouldn't give all extensions code access to these files. You can add a new DEPS file exactly where you need it. > > OTOH, these two are already in content/public/renderer/DEPS. Whoops missed this reply, DEPS should always be narrowly scoped. So add this to the same directory as the rest as these files. ddorwin 2016/04/08 17:56:56 In the new location, add a TODO to remove this one In the new location, add a TODO to remove this one when https://crbug.com/432381 is addressed. That is the only reason it's required currently. Mikhail 2016/04/08 18:28:58 Thanks for the proposal, I'll create a new DEPS in Show quoted text On 2016/04/08 17:41:31, ddorwin wrote: > It seems that we shouldn't give all extensions code access to these files. You > can add a new DEPS file exactly where you need it. Thanks for the proposal, I'll create a new DEPS in the following patch Show quoted text > > OTOH, these two are already in content/public/renderer/DEPS. Mikhail 2016/04/08 19:28:00 Done. Show quoted text On 2016/04/08 17:41:31, ddorwin wrote: > It seems that we shouldn't give all extensions code access to these files. You > can add a new DEPS file exactly where you need it. > > OTOH, these two are already in content/public/renderer/DEPS. Done.
	8 "+media/video",

7 "+mojo/edk/js",	9 "+mojo/edk/js",

8	10

9 "+third_party/skia/include/core",	11 "+third_party/skia/include/core",

10 "+third_party/cld_2/src/public/compact_lang_det.h",	12 "+third_party/cld_2/src/public/compact_lang_det.h",

11 "+third_party/cld_2/src/public/encodings.h",	13 "+third_party/cld_2/src/public/encodings.h",

12	14

13 "+third_party/WebKit/public/platform",	15 "+third_party/WebKit/public/platform",

14 "+third_party/WebKit/public/web",	16 "+third_party/WebKit/public/web",

15	17

16 "+third_party/wds/src/libwds/public",	18 "+third_party/wds/src/libwds/public",

17	19

18 "+tools/json_schema_compiler",	20 "+tools/json_schema_compiler",

19	21

20 "-v8",	22 "-v8",

21 "+v8/include",	23 "+v8/include",

22	24

23 "+storage/common/fileapi",	25 "+storage/common/fileapi",

24 ]	26 ]

25	27

OLD	NEW