Chromium Code Reviews

Side by Side Diff: src/code-stubs.cc

Issue 1860043002: [stubs] Introduce MultiplyStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « src/code-stubs.h ('k') | src/compiler/code-stub-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1013 matching lines...)
1024 assembler->Bind(&do_fsub); 1024 assembler->Bind(&do_fsub);
1025 { 1025 {
1026 Node* lhs_value = var_fsub_lhs.value(); 1026 Node* lhs_value = var_fsub_lhs.value();
1027 Node* rhs_value = var_fsub_rhs.value(); 1027 Node* rhs_value = var_fsub_rhs.value();
1028 Node* value = assembler->Float64Sub(lhs_value, rhs_value); 1028 Node* value = assembler->Float64Sub(lhs_value, rhs_value);
1029 Node* result = assembler->ChangeFloat64ToTagged(value); 1029 Node* result = assembler->ChangeFloat64ToTagged(value);
1030 assembler->Return(result); 1030 assembler->Return(result);
1031 } 1031 }
1032 } 1032 }
1033 1033
1034 void MultiplyStub::GenerateAssembly(
1035 compiler::CodeStubAssembler* assembler) const {
1036 using compiler::Node;
1037 typedef compiler::CodeStubAssembler::Label Label;
1038 typedef compiler::CodeStubAssembler::Variable Variable;
1039
1040 Node* context = assembler->Parameter(2);
1041
1042 // Shared entry point for floating point multiplication.
1043 Label do_fmul(assembler);
1044 Variable var_lhs_float64(assembler, MachineRepresentation::kFloat64),
1045 var_rhs_float64(assembler, MachineRepresentation::kFloat64);
1046
1047 Node* number_map = assembler->HeapNumberMapConstant();
1048
1049 // We might need to loop one or two times due to ToNumber conversions.
1050 Variable var_lhs(assembler, MachineRepresentation::kTagged),
1051 var_rhs(assembler, MachineRepresentation::kTagged);
1052 Variable* loop_variables[] = {&var_lhs, &var_rhs};
1053 Label loop(assembler, 2, loop_variables);
1054 var_lhs.Bind(assembler->Parameter(0));
1055 var_rhs.Bind(assembler->Parameter(1));
1056 assembler->Goto(&loop);
1057 assembler->Bind(&loop);
1058 {
1059 Node* lhs = var_lhs.value();
1060 Node* rhs = var_rhs.value();
1061
1062 Label lhs_is_smi(assembler), lhs_is_not_smi(assembler);
1063 assembler->Branch(assembler->WordIsSmi(lhs), &lhs_is_smi, &lhs_is_not_smi);
1064
1065 assembler->Bind(&lhs_is_smi);
1066 {
1067 Label rhs_is_smi(assembler), rhs_is_not_smi(assembler);
1068 assembler->Branch(assembler->WordIsSmi(rhs), &rhs_is_smi,
1069 &rhs_is_not_smi);
1070
1071 assembler->Bind(&rhs_is_smi);
1072 {
1073 // Both {lhs} and {rhs} are Smis. Convert them to double and multiply.
Benedikt Meurer 2016/04/06 04:04:58 Nit: Please put a TODO here, that we use SmiMulWit
epertoso 2016/04/06 08:38:49 Done.
1074 var_lhs_float64.Bind(assembler->SmiToFloat64(lhs));
1075 var_rhs_float64.Bind(assembler->SmiToFloat64(rhs));
1076 assembler->Goto(&do_fmul);
1077 }
1078
1079 assembler->Bind(&rhs_is_not_smi);
1080 {
1081 Node* rhs_map = assembler->LoadMap(rhs);
1082
1083 // Check if {rhs} is a HeapNumber.
1084 Label rhs_is_number(assembler),
1085 rhs_is_not_number(assembler, Label::kDeferred);
1086 assembler->Branch(assembler->WordEqual(rhs_map, number_map),
1087 &rhs_is_number, &rhs_is_not_number);
1088
1089 assembler->Bind(&rhs_is_number);
1090 {
1091 // Convert {lhs} to a double and multiply it with the value of {rhs}.
1092 var_lhs_float64.Bind(assembler->SmiToFloat64(lhs));
1093 var_rhs_float64.Bind(assembler->LoadHeapNumberValue(rhs));
1094 assembler->Goto(&do_fmul);
1095 }
1096
1097 assembler->Bind(&rhs_is_not_number);
1098 {
1099 // Multiplication is commutative, swap {lhs} with {rhs} and loop.
1100 var_lhs.Bind(rhs);
1101 var_rhs.Bind(lhs);
1102 assembler->Goto(&loop);
1103 }
1104 }
1105 }
1106
1107 assembler->Bind(&lhs_is_not_smi);
1108 {
1109 Node* lhs_map = assembler->LoadMap(lhs);
1110
1111 // Check if {lhs} is a HeapNumber.
1112 Label lhs_is_number(assembler),
1113 lhs_is_not_number(assembler, Label::kDeferred);
1114 assembler->Branch(assembler->WordEqual(lhs_map, number_map),
1115 &lhs_is_number, &lhs_is_not_number);
1116
1117 assembler->Bind(&lhs_is_number);
1118 {
1119 // Check if {rhs} is a Smi.
1120 Label rhs_is_smi(assembler), rhs_is_not_smi(assembler);
1121 assembler->Branch(assembler->WordIsSmi(rhs), &rhs_is_smi,
1122 &rhs_is_not_smi);
1123
1124 assembler->Bind(&rhs_is_smi);
1125 {
1126 // Convert {rhs} to a double and multiply it with the value of {lhs}.
1127 var_lhs_float64.Bind(assembler->LoadHeapNumberValue(lhs));
1128 var_rhs_float64.Bind(assembler->SmiToFloat64(rhs));
1129 assembler->Goto(&do_fmul);
1130 }
1131
1132 assembler->Bind(&rhs_is_not_smi);
1133 {
1134 Node* rhs_map = assembler->LoadMap(rhs);
1135
1136 // Check if {rhs} is a HeapNumber.
1137 Label rhs_is_number(assembler),
1138 rhs_is_not_number(assembler, Label::kDeferred);
1139 assembler->Branch(assembler->WordEqual(rhs_map, number_map),
1140 &rhs_is_number, &rhs_is_not_number);
1141
1142 assembler->Bind(&rhs_is_number);
1143 {
1144 // Both {lhs} and {rhs} are HeapNumbers. Load their values and
1145 // multiply them.
1146 var_lhs_float64.Bind(assembler->LoadHeapNumberValue(lhs));
1147 var_rhs_float64.Bind(assembler->LoadHeapNumberValue(rhs));
1148 assembler->Goto(&do_fmul);
1149 }
1150
1151 assembler->Bind(&rhs_is_not_number);
1152 {
1153 // Multiplication is commutative, swap {lhs} with {rhs} and loop.
1154 var_lhs.Bind(rhs);
1155 var_rhs.Bind(lhs);
1156 assembler->Goto(&loop);
1157 }
1158 }
1159 }
1160
1161 assembler->Bind(&lhs_is_not_number);
1162 {
1163 // Convert {lhs} to a Number and loop.
1164 Callable callable = CodeFactory::NonNumberToNumber(isolate());
1165 var_lhs.Bind(assembler->CallStub(callable, context, lhs));
1166 assembler->Goto(&loop);
1167 }
1168 }
1169 }
1170
1171 assembler->Bind(&do_fmul);
1172 {
1173 Node* value =
1174 assembler->Float64Mul(var_lhs_float64.value(), var_rhs_float64.value());
1175 Node* result = assembler->ChangeFloat64ToTagged(value);
1176 assembler->Return(result);
1177 }
1178 }
1179
1034 void BitwiseAndStub::GenerateAssembly( 1180 void BitwiseAndStub::GenerateAssembly(
1035 compiler::CodeStubAssembler* assembler) const { 1181 compiler::CodeStubAssembler* assembler) const {
1036 using compiler::Node; 1182 using compiler::Node;
1037 1183
1038 Node* lhs = assembler->Parameter(0); 1184 Node* lhs = assembler->Parameter(0);
1039 Node* rhs = assembler->Parameter(1); 1185 Node* rhs = assembler->Parameter(1);
1040 Node* context = assembler->Parameter(2); 1186 Node* context = assembler->Parameter(2);
1041 Node* lhs_value = assembler->TruncateTaggedToWord32(context, lhs); 1187 Node* lhs_value = assembler->TruncateTaggedToWord32(context, lhs);
1042 Node* rhs_value = assembler->TruncateTaggedToWord32(context, rhs); 1188 Node* rhs_value = assembler->TruncateTaggedToWord32(context, rhs);
1043 Node* value = assembler->Word32And(lhs_value, rhs_value); 1189 Node* value = assembler->Word32And(lhs_value, rhs_value);
(...skipping 2470 matching lines...)
3514 if (type->Is(Type::UntaggedPointer())) { 3660 if (type->Is(Type::UntaggedPointer())) {
3515 return Representation::External(); 3661 return Representation::External();
3516 } 3662 }
3517 3663
3518 DCHECK(!type->Is(Type::Untagged())); 3664 DCHECK(!type->Is(Type::Untagged()));
3519 return Representation::Tagged(); 3665 return Representation::Tagged();
3520 } 3666 }
3521 3667
3522 } // namespace internal 3668 } // namespace internal
3523 } // namespace v8 3669 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/compiler/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine