[stubs] Introduce MultiplyStub.

[stubs] Introduce MultiplyStub.

Adds a MultiplyStub for the multiplication operator and hooks it with TurboFan and Ignition.

Currently, the SMI times SMI case is handled by converting both the operands to double precision floating points, we may consider adding a fast path later.

Committed: https://crrev.com/6c2bb8389df148b02fc99b78872e7e700381c7f6
Cr-Commit-Position: refs/heads/master@{#35287}

[epertoso, 2016-04-05 15:13:24]

Description was changed from

==========
[stubs] Introduce MultiplyStub.

Adds a MultiplyStub for the multiplication operator and hooks it with TurboFan
and Ignition.

Currently, the SMI times SMI case is handled by converting both the operands to
double precision floating points, we may consider adding a fast path later.

BUG=
==========

to

==========
[stubs] Introduce MultiplyStub.

Adds a MultiplyStub for the multiplication operator and hooks it with TurboFan
and Ignition.

Currently, the SMI times SMI case is handled by converting both the operands to
double precision floating points, we may consider adding a fast path later.
==========

[epertoso, 2016-04-05 15:13:24]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[epertoso, 2016-04-05 15:13:24]

epertoso@chromium.org changed required reviewers:
+ bmeurer@chromium.org

[epertoso, 2016-04-05 15:54:49]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 15:54:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860043002/1

[commit-bot: I haz the power, 2016-04-05 16:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 16:18:05]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-04-06 04:04:58]

LGTM with nit.

https://codereview.chromium.org/1860043002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1860043002/diff/1/src/code-stubs.cc#newcode1073
src/code-stubs.cc:1073: // Both {lhs} and {rhs} are Smis. Convert them to double
and multiply.
Nit: Please put a TODO here, that we use SmiMulWithOverflow (which maps to
either IntPtrMulWithOverflow) once available.

[epertoso, 2016-04-06 08:38:49]

https://codereview.chromium.org/1860043002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1860043002/diff/1/src/code-stubs.cc#newcode1073
src/code-stubs.cc:1073: // Both {lhs} and {rhs} are Smis. Convert them to double
and multiply.
On 2016/04/06 at 04:04:58, Benedikt Meurer wrote:
> Nit: Please put a TODO here, that we use SmiMulWithOverflow (which maps to
either IntPtrMulWithOverflow) once available.

Done.

[epertoso, 2016-04-06 08:40:15]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-06 08:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1860043002/#ps20001
(title: "Update.")

[commit-bot: I haz the power, 2016-04-06 08:40:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860043002/20001

[commit-bot: I haz the power, 2016-04-06 09:05:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 09:05:48]

Description was changed from

==========
[stubs] Introduce MultiplyStub.

Adds a MultiplyStub for the multiplication operator and hooks it with TurboFan
and Ignition.

Currently, the SMI times SMI case is handled by converting both the operands to
double precision floating points, we may consider adding a fast path later.
==========

to

==========
[stubs] Introduce MultiplyStub.

Adds a MultiplyStub for the multiplication operator and hooks it with TurboFan
and Ignition.

Currently, the SMI times SMI case is handled by converting both the operands to
double precision floating points, we may consider adding a fast path later.

Committed: https://crrev.com/6c2bb8389df148b02fc99b78872e7e700381c7f6
Cr-Commit-Position: refs/heads/master@{#35287}
==========

[commit-bot: I haz the power, 2016-04-06 09:05:49]

Patchset 2 (id:??) landed as
https://crrev.com/6c2bb8389df148b02fc99b78872e7e700381c7f6
Cr-Commit-Position: refs/heads/master@{#35287}