[perf] Add speedometer-ignition benchmark

tools/perf/benchmarks/v8.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 import shlex
 
 from core import path_util
 from core import perf_benchmark
 from page_sets import google_pages
 
 from measurements import v8_detached_context_age_in_gc
 from measurements import v8_gc_times
 import page_sets
 from telemetry import benchmark
 from telemetry import story
 from telemetry.timeline import tracing_category_filter
 from telemetry.web_perf import timeline_based_measurement
 from telemetry.web_perf.metrics import v8_gc_latency
 from telemetry.web_perf.metrics import v8_execution
 from telemetry.web_perf.metrics import smoothness
 from telemetry.web_perf.metrics import memory_timeline
 
+import v8_helper
 
-def EnableIgnition(options):
-  existing_js_flags = []
-  for extra_arg in options.extra_browser_args:
-    if extra_arg.startswith('--js-flags='):
-      existing_js_flags.extend(shlex.split(extra_arg[len('--js-flags='):]))
-  options.AppendExtraBrowserArgs([
-      # This overrides any existing --js-flags, hence we have to include the
-      # previous flags as well.
-      '--js-flags=--ignition %s' % (' '.join(existing_js_flags))
-  ])
+
+def CreateV8TimelineBasedMeasurementOptions(benchmark):

[nednguyen, 2016/04/05 14:43:16]

You don't need the benchmark param. Did the pylint warn about unused param? If
not, lemme know since it's probably a bug.

Also to remove the boiler plates in benchmarks that use this, you can create s.t
like _TimelineBasedV8Benchmark with CreateTimelineBasedMeasurementOptions(self)
being this one & have your other v8 benchmarks subclass it.

[Camillo Bruni, 2016/04/06 08:10:25]

since I accidentally created v8_helper.py in the current working directory the
pylint messages didn't make sense, corrected that now.

+  category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
+  category_filter.AddIncludedCategory('v8')
+  category_filter.AddIncludedCategory('blink.console')
+  options = timeline_based_measurement.Options(category_filter)
+  options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
+  return options
 
 
 @benchmark.Disabled('win')        # crbug.com/416502
 class V8Top25(perf_benchmark.PerfBenchmark):
   """Measures V8 GC metrics on the while scrolling down the top 25 web pages.
 
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
   test = v8_gc_times.V8GCTimes
   page_set = page_sets.V8Top25SmoothPageSet
 
@@ skipping 92 matching lines @@
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
 
 class V8TodoMVC(perf_benchmark.PerfBenchmark):
   """Measures V8 Execution metrics on the TodoMVC examples."""
   page_set = page_sets.TodoMVCPageSet
 
   def CreateTimelineBasedMeasurementOptions(self):
-    category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
-    category_filter.AddIncludedCategory('v8')
-    category_filter.AddIncludedCategory('blink.console')
-    options = timeline_based_measurement.Options(category_filter)
-    options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
-    return options
+    return CreateV8TimelineBasedMeasurementOptions(self)
 
   @classmethod
   def Name(cls):
     return 'v8.todomvc'
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
 
-@benchmark.Disabled('reference')  # https://crbug.com/598096
-class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark):
-  """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
-  page_set = page_sets.TodoMVCPageSet
-
-  def SetExtraBrowserOptions(self, options):
-    EnableIgnition(options)
-
-  def CreateTimelineBasedMeasurementOptions(self):
-    category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
-    category_filter.AddIncludedCategory('v8')
-    category_filter.AddIncludedCategory('blink.console')
-    options = timeline_based_measurement.Options(category_filter)
-    options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
-    return options
-
-  @classmethod
-  def Name(cls):
-    return 'v8.todomvc-ignition'
-
-  @classmethod
-  def ShouldTearDownStateAfterEachStoryRun(cls):
-    return True
-
-
 # Disabled on reference builds because they don't support the new
 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
-@benchmark.Disabled('reference')  # crbug.com/579546
-class V8InfiniteScrollIgnition(_InfiniteScrollBenchmark):
-  """Measures V8 GC metrics using Ignition."""
-
-  page_set = page_sets.InfiniteScrollPageSet
+@benchmark.Disabled('reference') 
+class V8TodoMVCIgnition(V8TodoMVC):
+  """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
+  page_set = page_sets.TodoMVCPageSet
 
   def SetExtraBrowserOptions(self, options):
-    _InfiniteScrollBenchmark.SetExtraBrowserOptions(self,options)
-    EnableIgnition(options)
+    super(V8TodoMVCIgnition, self).SetExtraBrowserOptions(options)
+    v8_helper.EnableIgnition(options)
 
   @classmethod
   def Name(cls):
-    return 'v8.infinite_scroll-ignition'
+    return 'v8.todomvc-ignition'
 
 
 # Disabled on reference builds because they don't support the new
 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
 @benchmark.Disabled('reference')
 class V8InfiniteScroll(_InfiniteScrollBenchmark):
   """Measures V8 GC metrics and memory usage while scrolling the top web pages.
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
 
   page_set = page_sets.InfiniteScrollPageSet
 
   @classmethod
   def Name(cls):
     return 'v8.infinite_scroll'
 
 
+# Disabled on reference builds because they don't support the new
+# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
+@benchmark.Disabled('reference')  # crbug.com/579546
+class V8InfiniteScrollIgnition(V8InfiniteScroll):
+  """Measures V8 GC metrics using Ignition."""
+
+  def SetExtraBrowserOptions(self, options):
+    super(V8InfiniteScrollIgnition, self).SetExtraBrowserOptions(options)
+    v8_helper.EnableIgnition(options)
+
+  @classmethod
+  def Name(cls):
+    return 'v8.infinite_scroll-ignition'
+
+
 @benchmark.Enabled('android')
 class V8MobileInfiniteScroll(_InfiniteScrollBenchmark):
   """Measures V8 GC metrics and memory usage while scrolling the top mobile
   web pages.
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
 
   page_set = page_sets.MobileInfiniteScrollPageSet
 
   @classmethod
   def Name(cls):
     return 'v8.mobile_infinite_scroll'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):  # http://crbug.com/597656
       return (possible_browser.browser_type == 'reference' and
               possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
 
 
 class V8Adword(perf_benchmark.PerfBenchmark):
   """Measures V8 Execution metrics on the Adword page."""
 
   def CreateTimelineBasedMeasurementOptions(self):
-
-    category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
-    category_filter.AddIncludedCategory('v8')
-    category_filter.AddIncludedCategory('blink.console')
-    options = timeline_based_measurement.Options(category_filter)
-    options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])
-    return options
+    return CreateV8TimelineBasedMeasurementOptions(self)
 
   def CreateStorySet(self, options):
     """Creates the instance of StorySet used to run the benchmark.
 
     Can be overridden by subclasses.
     """
     story_set = story.StorySet(
         archive_data_file=os.path.join(
             path_util.GetPerfStorySetsDir(), 'data', 'v8_pages.json'),
         cloud_storage_bucket=story.PARTNER_BUCKET)
     story_set.AddStory(google_pages.AdwordCampaignDesktopPage(story_set))
     return story_set
 
   @classmethod
   def Name(cls):
     return 'v8.google'
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     return cls.IsSvelte(possible_browser) # http://crbug.com/596556
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True