Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1860003003: Remove the WebPNetworkClient* from iOS (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)
Modified:
4 years, 8 months ago
Reviewers:
sdefresne
CC:
cbentzel+watch_chromium.org, chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the WebPNetworkClient* from iOS In WKWebView one can no longer hook into the network stack to process WebP, so the code is no longer used. BUG=598730 Committed: https://crrev.com/96ae149a305186452c153f40a3b88fda7a26252e Cr-Commit-Position: refs/heads/master@{#385279}

Patch Set 1 #

Patch Set 2 : Fix build files #

Patch Set 3 : Build fix No. 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -418 lines) Patch
M components/components_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/webp_transcode.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/webp_transcode/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
D components/webp_transcode/webp_network_client.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/webp_transcode/webp_network_client.mm View 1 chunk +0 lines, -231 lines 0 comments Download
D components/webp_transcode/webp_network_client_factory.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/webp_transcode/webp_network_client_factory.mm View 1 chunk +0 lines, -42 lines 0 comments Download
D components/webp_transcode/webp_network_client_unittest.mm View 1 chunk +0 lines, -75 lines 0 comments Download
M ios/crnet/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/crnet/crnet.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ios/crnet/crnet_environment.mm View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi Sylvain, PTAL. Thanks! Vaclav
4 years, 8 months ago (2016-04-05 19:35:54 UTC) #2
sdefresne
LGTM Can you send it to the downstream bots to check this does not break ...
4 years, 8 months ago (2016-04-05 20:07:33 UTC) #3
vabr (Chromium)
On 2016/04/05 20:07:33, sdefresne wrote: > LGTM > > Can you send it to the ...
4 years, 8 months ago (2016-04-05 20:29:11 UTC) #4
vabr (Chromium)
On 2016/04/05 20:29:11, vabr (Chromium) wrote: > On 2016/04/05 20:07:33, sdefresne wrote: > > LGTM ...
4 years, 8 months ago (2016-04-05 20:32:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860003003/40001
4 years, 8 months ago (2016-04-05 20:32:59 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 20:42:55 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 20:43:51 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96ae149a305186452c153f40a3b88fda7a26252e
Cr-Commit-Position: refs/heads/master@{#385279}

Powered by Google App Engine
This is Rietveld 408576698