Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1860003002: Revert of [api] Restrict Template::Set to take templates or primitive values (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Restrict Template::Set to take templates or primitive values (patchset #1 id:1 of https://codereview.chromium.org/1839983002/ ) Reason for revert: Breaks node.js Original issue's description: > [api] Restrict Template::Set to take templates or primitive values > > Embedders that passed in non-primitive values should either use > getters/setters (templates) or install a native data property, > otherwise, the values would all result in cross-context leaks > > BUG=none > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 > Cr-Commit-Position: refs/heads/master@{#35244} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/e1674a24ca3cb92bb4e58d368b25767bd61a0dfa Cr-Commit-Position: refs/heads/master@{#35264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M include/v8.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
Created Revert of [api] Restrict Template::Set to take templates or primitive values
4 years, 8 months ago (2016-04-05 14:13:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860003002/1
4 years, 8 months ago (2016-04-05 14:13:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 14:13:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1674a24ca3cb92bb4e58d368b25767bd61a0dfa Cr-Commit-Position: refs/heads/master@{#35264}
4 years, 8 months ago (2016-04-05 14:15:41 UTC) #5
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-18 10:44:13 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1894993002/ by jochen@chromium.org.

The reason for reverting is: node.js is updated now.

Powered by Google App Engine
This is Rietveld 408576698