Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1859993002: Revert of [api] Restrict Template::Set to take templates or primitive values (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Restrict Template::Set to take templates or primitive values (patchset #1 id:1 of https://codereview.chromium.org/1839983002/ ) Reason for revert: Breaks node.js Original issue's description: > [api] Restrict Template::Set to take templates or primitive values > > Embedders that passed in non-primitive values should either use > getters/setters (templates) or install a native data property, > otherwise, the values would all result in cross-context leaks > > BUG=none > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 > Cr-Commit-Position: refs/heads/master@{#35244} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M include/v8.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jochen (gone - plz use gerrit)
Created Revert of [api] Restrict Template::Set to take templates or primitive values
4 years, 8 months ago (2016-04-05 14:13:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859993002/1
4 years, 8 months ago (2016-04-05 14:13:40 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 14:15:03 UTC) #4
Failed to apply patch for include/v8.h:
While running git apply --index -3 -p1;
  error: patch failed: include/v8.h:4102
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: include/v8.h: patch does not apply

Patch:       include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
b01a8cc54fe4e452bedd64832e95554c7c658429..db2178b73becb2c7ad76a5f28e8b81e4c14d1c33
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4102,11 +4102,7 @@
  */
 class V8_EXPORT Template : public Data {
  public:
-  /**
-   * Adds a property to each instance created by this template.
-   *
-   * The property must be defined either as a primitive value, or a template.
-   */
+  /** Adds a property to each instance created by this template.*/
   void Set(Local<Name> name, Local<Data> value,
            PropertyAttribute attributes = None);
   V8_INLINE void Set(Isolate* isolate, const char* name, Local<Data> value);

Powered by Google App Engine
This is Rietveld 408576698