Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859973002: Autoformat tools/testing/dart (Closed)

Created:
4 years, 8 months ago by Bill Hesse
Modified:
4 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Format the test scripts in /tools/testing/dart using dartfmt 1.16.0-dev.3.0. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/c63b10b6117b2f34616666fd857a6bbb0a56753d

Patch Set 1 #

Patch Set 2 : Format whole directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2039 lines, -2226 lines) Patch
M tools/testing/dart/android.dart View 1 8 chunks +54 lines, -36 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 1 45 chunks +211 lines, -193 lines 0 comments Download
D tools/testing/dart/browser_perf_testing/pubspec.yaml View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 1 2 chunks +25 lines, -14 lines 0 comments Download
M tools/testing/dart/co19_test_config.dart View 1 1 chunk +8 lines, -9 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 20 chunks +138 lines, -168 lines 0 comments Download
M tools/testing/dart/dependency_graph.dart View 1 2 chunks +6 lines, -7 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 1 3 chunks +10 lines, -8 lines 0 comments Download
M tools/testing/dart/html_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 15 chunks +63 lines, -76 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 6 chunks +25 lines, -28 lines 0 comments Download
M tools/testing/dart/path.dart View 1 7 chunks +22 lines, -28 lines 0 comments Download
M tools/testing/dart/record_and_replay.dart View 1 6 chunks +11 lines, -12 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 13 chunks +34 lines, -46 lines 0 comments Download
M tools/testing/dart/status_expression.dart View 1 14 chunks +12 lines, -28 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 8 chunks +17 lines, -29 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 1 3 chunks +73 lines, -66 lines 0 comments Download
M tools/testing/dart/summary_report.dart View 1 2 chunks +14 lines, -14 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 11 chunks +65 lines, -59 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 18 chunks +399 lines, -411 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 1 21 chunks +79 lines, -85 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 89 chunks +387 lines, -451 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 67 chunks +330 lines, -389 lines 0 comments Download
M tools/testing/dart/utils.dart View 1 9 chunks +49 lines, -48 lines 0 comments Download
M tools/testing/dart/vm_test_config.dart View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
Pass two testing files through the Dart formatter, to restore them to the standard format.
4 years, 8 months ago (2016-04-05 12:29:05 UTC) #2
ahe
On average, LGTM
4 years, 8 months ago (2016-04-05 12:43:06 UTC) #3
Bill Hesse
On 2016/04/05 12:43:06, ahe wrote: > On average, LGTM This CL will be applied after ...
4 years, 8 months ago (2016-04-05 12:54:19 UTC) #4
Bill Hesse
4 years, 8 months ago (2016-04-06 12:49:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c63b10b6117b2f34616666fd857a6bbb0a56753d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698