Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1859943003: [tools/perf] Explicitly enable display tracing for smoothness metric (Closed)

Created:
4 years, 8 months ago by perezju
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Explicitly enable display tracing for smoothness metric BUG=catapult:#2205 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/d469ba8f0b17316e7f438ab1ac5a80a3e641fffc Cr-Commit-Position: refs/heads/master@{#385312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/measurements/smoothness.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
perezju
This is currently a no-op, since display tracing is always enabled by default. Must be ...
4 years, 8 months ago (2016-04-05 11:58:43 UTC) #3
nednguyen
lgtm
4 years, 8 months ago (2016-04-05 13:09:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859943003/1
4 years, 8 months ago (2016-04-05 13:28:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/108)
4 years, 8 months ago (2016-04-05 22:29:42 UTC) #9
nednguyen
On 2016/04/05 22:29:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-05 22:33:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859943003/1
4 years, 8 months ago (2016-04-05 22:37:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 22:49:47 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:51:11 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d469ba8f0b17316e7f438ab1ac5a80a3e641fffc
Cr-Commit-Position: refs/heads/master@{#385312}

Powered by Google App Engine
This is Rietveld 408576698