Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: content/renderer/render_view_impl.cc

Issue 185993008: Moving DidFinishLoad from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes based on Charlie's review. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index bf4357f926a73e19a462773b0bd7077aed2f0845..44fc0766ed3c3c73de9b496ff9d48862e754b796 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3090,28 +3090,7 @@ void RenderViewImpl::didFailLoad(WebFrame* frame, const WebURLError& error) {
}
void RenderViewImpl::didFinishLoad(WebFrame* frame) {
- WebDataSource* ds = frame->dataSource();
- DocumentState* document_state = DocumentState::FromDataSource(ds);
- if (document_state->finish_load_time().is_null()) {
- if (!frame->parent()) {
- TRACE_EVENT_INSTANT0("WebCore", "LoadFinished",
- TRACE_EVENT_SCOPE_PROCESS);
- }
- document_state->set_finish_load_time(Time::Now());
- }
-
FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidFinishLoad(frame));
-
- // Don't send this message while the subframe is swapped out.
- // TODO(creis): This whole method should move to RenderFrame.
- RenderFrameImpl* rf = RenderFrameImpl::FromWebFrame(frame);
- if (rf && rf->is_swapped_out())
- return;
-
- Send(new ViewHostMsg_DidFinishLoad(routing_id_,
- rf->GetRoutingID(),
- ds->request().url(),
- !frame->parent()));
}
void RenderViewImpl::didNavigateWithinPage(
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698