content/browser/web_contents/web_contents_impl_unittest.cc - Issue 185993008: Moving DidFinishLoad from RenderView to RenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 185993008: Moving DidFinishLoad from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on Charlie's review. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index 1a96496da949fd85607d5dc6e721b30e5b47ad8e..0a1c366bddb56ea3096fe2259a445d55f298ed71 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -2149,7 +2149,7 @@ TEST_F(WebContentsImplTest, FilterURLs) {

contents()->NavigateAndCommit(url_normalized);

// Check that an IPC with about:whatever is correctly normalized.

- contents()->TestDidFinishLoad(1, url_from_ipc, true);

+ contents()->TestDidFinishLoad(url_from_ipc, true);

EXPECT_EQ(url_normalized, observer.last_url());

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »