content/browser/web_contents/web_contents_impl.h - Issue 185993008: Moving DidFinishLoad from RenderView to RenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 185993008: Moving DidFinishLoad from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on Charlie's review. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index c798c55bac387b4737d0b28c8d222b1f0337407a..fea0e9e57bdd61b1de9c6c646fe9b192ad59add0 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -681,8 +681,7 @@ class CONTENT_EXPORT WebContentsImpl

void OnDidRunInsecureContent(const std::string& security_origin,

const GURL& target_url);

void OnDocumentLoadedInFrame();

- void OnDidFinishLoad(int64 frame_id,

- const GURL& url,

+ void OnDidFinishLoad(const GURL& url,

bool is_main_frame);

void OnGoToEntryAtOffset(int offset);

void OnUpdateZoomLimits(int minimum_percent,

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »