Moving DidFinishLoad from RenderView to RenderFrame.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 1538 matching lines @@
       &error_description);
   Send(new FrameHostMsg_DidFailLoadWithError(routing_id_,
                                              failed_request.url(),
                                              !frame->parent(),
                                              error.reason,
                                              error_description));
 }
 
 void RenderFrameImpl::didFinishLoad(blink::WebFrame* frame) {
   DCHECK(!frame_ || frame_ == frame);
-  // TODO(nasko): Move implementation here. No state needed, just observers
-  // notification before sending message to the browser process.
+  WebDataSource* ds = frame->dataSource();
+  DocumentState* document_state = DocumentState::FromDataSource(ds);
+  if (document_state->finish_load_time().is_null()) {
+    if (!frame->parent()) {
+      TRACE_EVENT_INSTANT0("WebCore", "LoadFinished",
+                           TRACE_EVENT_SCOPE_PROCESS);
+    }
+    document_state->set_finish_load_time(Time::Now());
+  }
+
   render_view_->didFinishLoad(frame);
-  FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
-                    DidFinishLoad());
+  FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidFinishLoad());
+
+  // Don't send this message while the frame is swapped out.
+  if (is_swapped_out())
+    return;
+
+  Send(new FrameHostMsg_DidFinishLoad(routing_id_,
+                                     ds->request().url(),

[Charlie Reis, 2014/03/05 18:50:26]

nit: 1 more space indent.

[nasko, 2014/03/05 19:00:46]

Done.

+                                     !frame->parent()));
 }
 
 void RenderFrameImpl::didNavigateWithinPage(blink::WebFrame* frame,
                                             bool is_new_navigation) {
   DCHECK(!frame_ || frame_ == frame);
   // If this was a reference fragment navigation that we initiated, then we
   // could end up having a non-null pending navigation params.  We just need to
   // update the ExtraData on the datasource so that others who read the
   // ExtraData will get the new NavigationState.  Similarly, if we did not
   // initiate this navigation, then we need to take care to reset any pre-
@@ skipping 702 matching lines @@
 
 void RenderFrameImpl::didStartLoading() {
   Send(new FrameHostMsg_DidStartLoading(routing_id_));
 }
 
 void RenderFrameImpl::didStopLoading() {
   Send(new FrameHostMsg_DidStopLoading(routing_id_));
 }
 
 }  // namespace content