[PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value.

ppapi/shared_impl/var.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/var.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
 #include "ppapi/c/pp_var.h"
 #include "ppapi/shared_impl/ppapi_globals.h"
+#include "ppapi/shared_impl/resource_var.h"
 #include "ppapi/shared_impl/var_tracker.h"
 
 namespace ppapi {
 
 // Var -------------------------------------------------------------------------
 
 Var::Var() : var_id_(0) {
 }
 
 Var::~Var() {
@@ skipping 31 matching lines @@
       return result;
     }
     case PP_VARTYPE_OBJECT:
       return "[Object]";
     case PP_VARTYPE_ARRAY:
       return "[Array]";
     case PP_VARTYPE_DICTIONARY:
       return "[Dictionary]";
     case PP_VARTYPE_ARRAY_BUFFER:
       return "[Array buffer]";
+    case PP_VARTYPE_RESOURCE: {
+      ResourceVar* resource(ResourceVar::FromPPVar(var));
+      if (!resource)
+        return "[Invalid resource]";
+
+      if (resource->pp_resource()) {
+        return base::StringPrintf("[Resource %d]", resource->pp_resource());
+      } else if (resource->creation_message().type() != 0) {

[raymes, 2013/09/11 22:52:29]

This makes me wonder whether maybe we should have an enum for specifying the
type of the resource var (i.e. either pending or existing). I'm ok with leaving
it as-is for now though.

[yzshen1, 2013/09/11 22:57:11]

Or maybe we could have some boolean method such as ResourceVar::IsPending()?

On 2013/09/11 22:52:29, raymes wrote:

[Matt Giuca, 2013/09/12 07:08:24]

Yeah OK. I think I'll add IsPending (it doesn't seem worth having an enum, since
it's really only used for this debug string), but I'll do it in another CL since
I want to submit this one without another review cycle.

+        return base::StringPrintf("[Pending resource]");
+      } else {
+        return "[Null resource]";
+      }
+    }
     default:
       return "[Invalid var]";
   }
 }
 
 StringVar* Var::AsStringVar() {
   return NULL;
 }
 
 ArrayBufferVar* Var::AsArrayBufferVar() {
@@ skipping 131 matching lines @@
     return NULL;
   scoped_refptr<Var> var_object(
       PpapiGlobals::Get()->GetVarTracker()->GetVar(var));
   if (!var_object.get())
     return NULL;
   return var_object->AsArrayBufferVar();
 }
 
 }  // namespace ppapi