src/deoptimizer.cc - Issue 1859763005: [crankshaft] Fix environment handling after leaving inlined tail call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/deoptimizer.cc

Issue 1859763005: [crankshaft] Fix environment handling after leaving inlined tail call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/deoptimizer.cc

diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc

index 2c330e378d0ce40568787f326693e80d48a4b664..a8405daee32428d8e52f4d32b5fceaf73bf04c92 100644

--- a/src/deoptimizer.cc

+++ b/src/deoptimizer.cc

@@ -1430,7 +1430,7 @@ void Deoptimizer::DoComputeTailCallerFrame(TranslatedFrame* translated_frame,

bool is_bottommost = (0 == frame_index);

// Tail caller frame can't be topmost.

- DCHECK_NE(output_count_ - 1, frame_index);

+ CHECK_NE(output_count_ - 1, frame_index);

if (trace_scope_ != NULL) {

PrintF(trace_scope_->file(), " translating tail caller frame ");

« no previous file with comments | « src/crankshaft/lithium.cc ('k') | test/mjsunit/regress/regress-crbug-537444.js » ('j') | no next file with comments »