Blimp: create Mojo component for renderer/browser communication.

blimp/engine/mojo/blob_channel_mojo_impl.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/engine/mojo/blob_channel_mojo_impl.h"
+
+namespace blimp {
+namespace engine {
+
+BlobChannelMojoImpl::BlobChannelMojoImpl(
+    mojo::InterfaceRequest<BlobChannelMojo> request)

[yzshen1, 2016/04/05 17:44:14]

nit: in case you didn't notice, you can use a shorter name
BlobChannelMojoRequest

[Kevin M, 2016/04/06 00:01:44]

Done.

+    : binding_(this, std::move(request)) {}
+
+BlobChannelMojoImpl::~BlobChannelMojoImpl() {}
+
+void BlobChannelMojoImpl::Put(const mojo::String& id,
+                              mojo::Array<uint8_t> data) {
+  NOTIMPLEMENTED();
+}
+
+void BlobChannelMojoImpl::Push(const mojo::String& id) {
+  NOTIMPLEMENTED();
+}
+
+// static
+void BlobChannelMojoImpl::Create(
+    mojo::InterfaceRequest<BlobChannelMojo> request) {
+  new BlobChannelMojoImpl(std::move(request));

[nyquist, 2016/04/05 22:13:19]

Does this ever get deleted? Does it happen automatically when the binding is
over?
If so; could you add a comment about this here, so it doesn't look like it's
just leaking?

[Kevin M, 2016/04/06 00:01:44]

Yes, its StrongBinding |binding_| controls the lifetime. Added comment.

+}
+
+}  // namespace engine
+}  // namespace blimp