blimp/engine/mojo/blob_channel.mojom - Issue 1859753002: Blimp: create Mojo component for renderer/browser communication.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/mojo/blob_channel.mojom

Issue 1859753002: Blimp: create Mojo component for renderer/browser communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module blimp.engine;

	6

	7 interface BlobChannelMojo {
	yzshen1 2016/04/05 17:44:14 I believe the convention is to use module/namespac I believe the convention is to use module/namespace "foo.mojom" (in this case blimp.engine.mojom) and don't have "Mojo"/"Mojom" in interface/struct/etc. names. Kevin M 2016/04/06 00:01:44 Done. Also removed "mojo" from the impl class name Show quoted text On 2016/04/05 17:44:14, yzshen1 wrote: > I believe the convention is to use module/namespace "foo.mojom" (in this case > blimp.engine.mojom) and don't have "Mojo"/"Mojom" in interface/struct/etc. > names. Done. Also removed "mojo" from the impl class name, so BlobChannelMojoImpl=>BlobChannelService.
	8 // Stores the blob \|id\| in the BlobCache.

	9 Put(string id, array<uint8> data);

	10

	11 // Requests that the BlobChannel push the blob \|id\| over the wire.

	12 // The request will be ignored if the BlobChannel knows that

	13 // the client already has the data.

	14 Push(string id);

	15 };

	16

OLD	NEW

« blimp/engine/mojo/BUILD.gn ('K') | « blimp/engine/mojo/BUILD.gn ('k') | blimp/engine/mojo/blob_channel_mojo_impl.h » ('j') | blimp/engine/mojo/blob_channel_mojo_impl.h » ('J')