Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1859733002: cc: Remove usage of Layer draw_transform (Closed)

Created:
4 years, 8 months ago by sunxd
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove usage of Layer draw_transform Remove the Layer version of DrawPropertyUtils::DrawTransform, remove Layer::draw_transform. Convert tests that use Layer's draw_transform to LayerImpl tests. BUG=599974 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5 Cr-Commit-Position: refs/heads/master@{#385184}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Resolve comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -163 lines) Patch
M cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/draw_property_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 3 chunks +4 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 7 chunks +104 lines, -137 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sunxd
4 years, 8 months ago (2016-04-04 20:45:01 UTC) #3
ajuma
https://codereview.chromium.org/1859733002/diff/1/cc/trees/draw_property_utils.cc File cc/trees/draw_property_utils.cc (right): https://codereview.chromium.org/1859733002/diff/1/cc/trees/draw_property_utils.cc#newcode822 cc/trees/draw_property_utils.cc:822: return DrawTransformInternal(layer, tree.Node(layer->transform_tree_index())); Since we no longer need templating, ...
4 years, 8 months ago (2016-04-04 22:15:59 UTC) #4
sunxd
https://codereview.chromium.org/1859733002/diff/1/cc/trees/draw_property_utils.cc File cc/trees/draw_property_utils.cc (right): https://codereview.chromium.org/1859733002/diff/1/cc/trees/draw_property_utils.cc#newcode822 cc/trees/draw_property_utils.cc:822: return DrawTransformInternal(layer, tree.Node(layer->transform_tree_index())); On 2016/04/04 22:15:59, ajuma wrote: > ...
4 years, 8 months ago (2016-04-05 14:26:48 UTC) #5
ajuma
Thanks, lgtm.
4 years, 8 months ago (2016-04-05 15:05:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859733002/20001
4 years, 8 months ago (2016-04-05 15:09:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 16:18:00 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 16:20:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5
Cr-Commit-Position: refs/heads/master@{#385184}

Powered by Google App Engine
This is Rietveld 408576698