gpu/tools/compositor_model_bench/shaders.cc - Issue 1859703002: convert //gpu to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/tools/compositor_model_bench/shaders.cc

Issue 1859703002: convert //gpu to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: undo part of clang-format Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/tools/compositor_model_bench/shaders.cc

diff --git a/gpu/tools/compositor_model_bench/shaders.cc b/gpu/tools/compositor_model_bench/shaders.cc

index 0ea6275efe7dbcb105378f585d8a252c7725abab..1ca5367fcdd278d404c74fe4daa821e77e089c9b 100644

--- a/gpu/tools/compositor_model_bench/shaders.cc

+++ b/gpu/tools/compositor_model_bench/shaders.cc

@@ -237,7 +237,7 @@ static void ReportAnyShaderCompilationErrors(GLuint shader, ShaderID id) {

// Get the length of the log string

GLsizei length;

glGetShaderiv(shader, GL_INFO_LOG_LENGTH, &length);

- scoped_ptr<GLchar[]> log(new GLchar[length+1]);

+ std::unique_ptr<GLchar[]> log(new GLchar[length + 1]);

glGetShaderInfoLog(shader, length, NULL, log.get());

LOG(ERROR) << log.get() << " in shader " << ShaderNameFromID(id);

}