gpu/command_buffer/build_gles2_cmd_buffer.py - Issue 1859703002: convert //gpu to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1859703002: convert //gpu to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: undo part of clang-format Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/build_gles2_cmd_buffer.py

diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py

index 4d94ddfb0b07d8f89846ac4a75b1337bf63e2d12..1b8ae7c7b8b380b14f67bc49d6d6374d898e10ca 100755

--- a/gpu/command_buffer/build_gles2_cmd_buffer.py

+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py

@@ -6159,7 +6159,7 @@ class GENnHandler(TypeHandler):

return error::kInvalidArguments;

}

- scoped_ptr<GLuint[]> service_ids(new GLuint[n]);

+ std::unique_ptr<GLuint[]> service_ids(new GLuint[n]);

gl%(func_name)s(n, service_ids.get());

for (GLsizei ii = 0; ii < n; ++ii) {

group_->Add%(resource_name)sId(%(last_arg_name)s[ii], service_ids[ii]);