Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1859693002:
Mark PDFExtensionTest.Navigator as flaky on ASAN. (Closed)
|
Created:
4 years, 8 months ago by Łukasz Anforowicz Modified:
4 years, 8 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jaydasika Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark PDFExtensionTest.Navigator as flaky on ASAN.
TBR=thestig@chromium.org
BUG=600445
Committed: https://crrev.com/072c6e44acd50c11ebe83d189de53daaa87a7b9f
Cr-Commit-Position: refs/heads/master@{#384995}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
lukasza@chromium.org changed reviewers: + danakj@chromium.org
Dana, could you please take a look? I want to mark this test as flaky as part of the sheriffing duty, but before doing that I wanted to positively identify an owner for the bug (https://crbug.com/600445) to make sure the test is reenabled later. Can you be "it" for now? (I know that you've only refactored the DCHECK, but you're also familiar with the "cc" layer, right?)
Looks like you have a good owner on the bug. LGTM (not an owner of this test tho)
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859693002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Mark PDFExtensionTest.Navigator as flaky on ASAN. BUG=600445 ========== to ========== Mark PDFExtensionTest.Navigator as flaky on ASAN. TBR=thestig@chromium.org BUG=600445 ==========
lukasza@chromium.org changed reviewers: + thestig@chromium.org
Lei, could you please take a look when you have a chance? (I'll add you to TBR as an owner of chrome/browser/pdf - it seems that one of the tests in this directory is intermittently trigerring a DCHECK in //cc layer - see the attached bug for more details).
+Jayadev to CC (as the current owner of https://crbug.com/600445)
The CQ bit was checked by lukasza@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859693002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Mark PDFExtensionTest.Navigator as flaky on ASAN. TBR=thestig@chromium.org BUG=600445 ========== to ========== Mark PDFExtensionTest.Navigator as flaky on ASAN. TBR=thestig@chromium.org BUG=600445 Committed: https://crrev.com/072c6e44acd50c11ebe83d189de53daaa87a7b9f Cr-Commit-Position: refs/heads/master@{#384995} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/072c6e44acd50c11ebe83d189de53daaa87a7b9f Cr-Commit-Position: refs/heads/master@{#384995}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
